Summary

Route GLib debug logging directly to the Finch debug window

Review Request #1057 — Created Oct. 17, 2021 and submitted Oct. 18, 2021, 3:06 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.

Testing Done

Open the Debug window an see some GLib-* outputs.

Commits

Summary	ID
Route GLib debug logging directly to the Finch debug window Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.	3cc90101d335327147edbe87457fcd31a8fcf58d

Issues

Description	From	Last Updated
weird whitespace?	grim	Oct. 18, 2021, 3:05 a.m.
Shouldn't these be or'd so that keyword searching works without the domain.	grim	Oct. 18, 2021, 2:43 a.m.

finch/gntdebug.c (Diff revision 1)

Show all issues

Shouldn't these be or'd so that keyword searching works without the domain.

QuLogic Oct. 18, 2021, 1:28 a.m.

Ah yea, it was split in the separate function, but should be joined when inlined here..

Change Summary:

Fix filtering.

Commits:

	Summary	ID
	Route GLib debug logging directly to the Finch debug window Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.	3c16e64f083051ef6497a926796a8423f7deb3aa
	Route GLib debug logging directly to the Finch debug window Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.	6f99b65993683fdf16eb8b36591b5e5b643b0288

Diff:

Revision 2 (+136 -102)

Show changes

finch/gntdebug.c

finch/gntdebug.c (Diff revisions 1 - 2)
Show all issues
```
weird whitespace?
```

Change Summary:

Fix formatting.

Commits:

	Summary	ID
	Route GLib debug logging directly to the Finch debug window Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.	6f99b65993683fdf16eb8b36591b5e5b643b0288
	Route GLib debug logging directly to the Finch debug window Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.	3cc90101d335327147edbe87457fcd31a8fcf58d

Diff:

Revision 3 (+138 -102)

Show changes

finch/gntdebug.c

Ship it!

```
Ship It!
```
```
Nice work, thanks!!
```

Review Board 6.0.2

Route GLib debug logging directly to the Finch debug window

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)