-
-
pidgin/gtkblist.c (Diff revision 1) If a conversation can never be hidden, then
pidgin_conv_is_hidden
can never beTRUE
?Then this (removed) condition is always true, and the rest of the function should be dead code, meaning the entire function is dead code.
-
-
Remove the hidden conversation window as that api is going to change in the future
Review Request #1005 — Created Oct. 8, 2021 and submitted
Remove the hidden conversation window as that api is going to change in the future
Created an im and joined a chat, verified they both worked. Also made sure the preferences window opened without issue.
Summary | ID |
---|---|
40b1caa126231874f5758f84ebd27f273c1d4df2 |
Description | From | Last Updated |
---|---|---|
If a conversation can never be hidden, then pidgin_conv_is_hidden can never be TRUE? Then this (removed) condition is always true, … |
QuLogic | |
These two conditions can be joined together? |
QuLogic | |
Should we remove this signal registration as well? |
QuLogic | |
It might be the case that all of these callbacks are not needed now? |
QuLogic | |
This condition (and comment) can be dropped now. |
QuLogic | |
Is it necessary to update the blist if the flags haven't changed? I think that was there to refresh the … |
QuLogic | |
Maybe just remove the else and put the reassignment in the if? |
QuLogic |
Change Summary:
addressed comments
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+56 -738) |
-
-
pidgin/gtkblist.c (Diff revision 2) It might be the case that all of these callbacks are not needed now?
Change Summary:
Replaced the PidginBlistNode.conv structure with just a pointer to a conversation as it's still used as a fast lookup when drawing tooltips.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+84 -898) |
-
-
-
pidgin/gtkblist.c (Diff revision 3) Is it necessary to update the blist if the flags haven't changed? I think that was there to refresh the icon, which now doesn't change since it's never hidden, unless there are other reasons for it to change?
-
Change Summary:
addressed concerns
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+120 -970) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+120 -970) |