Remove the hidden conversation window as that api is going to change in the future

Review Request #1005 — Created Oct. 8, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Remove the hidden conversation window as that api is going to change in the future

Created an im and joined a chat, verified they both worked. Also made sure the preferences window opened without issue.

Summary
Remove the hidden conversation window as that api is going to change in the future
Description From Last Updated

If a conversation can never be hidden, then pidgin_conv_is_hidden can never be TRUE? Then this (removed) condition is always true, ...

QuLogicQuLogic

These two conditions can be joined together?

QuLogicQuLogic

Should we remove this signal registration as well?

QuLogicQuLogic

It might be the case that all of these callbacks are not needed now?

QuLogicQuLogic

This condition (and comment) can be dropped now.

QuLogicQuLogic

Is it necessary to update the blist if the flags haven't changed? I think that was there to refresh the ...

QuLogicQuLogic

Maybe just remove the else and put the reassignment in the if?

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/gtkblist.c (Diff revision 1)
     
     

    If a conversation can never be hidden, then pidgin_conv_is_hidden can never be TRUE?

    Then this (removed) condition is always true, and the rest of the function should be dead code, meaning the entire function is dead code.

  3. pidgin/gtkconv.c (Diff revision 1)
     
     
     
     
     
     
     

    These two conditions can be joined together?

  4. pidgin/gtkconv.c (Diff revision 1)
     
     

    Should we remove this signal registration as well?

  5. 
      
grim
QuLogic
  1. 
      
  2. pidgin/gtkblist.c (Diff revision 2)
     
     
     
     
     
     
     

    It might be the case that all of these callbacks are not needed now?

    1. I thought I left a comment here saying the deleted_update_cb needs to remain for now as it's used to cache the conversation when updating tooltips.

  3. 
      
grim
QuLogic
  1. 
      
  2. pidgin/gtkblist.c (Diff revision 3)
     
     

    This condition (and comment) can be dropped now.

  3. pidgin/gtkblist.c (Diff revision 3)
     
     

    Is it necessary to update the blist if the flags haven't changed? I think that was there to refresh the icon, which now doesn't change since it's never hidden, unless there are other reasons for it to change?

  4. pidgin/gtkblist.c (Diff revision 3)
     
     

    Maybe just remove the else and put the reassignment in the if?

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...