Remove the hidden conversation window as that api is going to change in the future
Review Request #1005 — Created Oct. 8, 2021 and submitted
Remove the hidden conversation window as that api is going to change in the future
Created an im and joined a chat, verified they both worked. Also made sure the preferences window opened without issue.
| Summary | ID |
|---|---|
| 40b1caa126231874f5758f84ebd27f273c1d4df2 |
| Description | From | Last Updated |
|---|---|---|
|
If a conversation can never be hidden, then pidgin_conv_is_hidden can never be TRUE? Then this (removed) condition is always true, … |
 QuLogic
|
|
|
These two conditions can be joined together? |
QuLogic
|
|
|
Should we remove this signal registration as well? |
QuLogic
|
|
|
It might be the case that all of these callbacks are not needed now? |
QuLogic
|
|
|
This condition (and comment) can be dropped now. |
QuLogic
|
|
|
Is it necessary to update the blist if the flags haven't changed? I think that was there to refresh the … |
QuLogic
|
|
|
Maybe just remove the else and put the reassignment in the if? |
QuLogic
|
- Change Summary:
-
addressed comments
- Commits:
-
Summary ID 893d1f0b5704c850dcb7e970cda6aebec168ecec efab53bc37d28d1ba6056d79404d863d3f0af714
- Change Summary:
-
Replaced the PidginBlistNode.conv structure with just a pointer to a conversation as it's still used as a fast lookup when drawing tooltips.
- Commits:
-
Summary ID efab53bc37d28d1ba6056d79404d863d3f0af714 88d19bd343f3a202e864bcc10423ae67da704ca7
- Change Summary:
-
addressed concerns
- Commits:
-
Summary ID 88d19bd343f3a202e864bcc10423ae67da704ca7 bf4d2b8908c8a89276c6c973d50eeff3ab7d9bce