Create PurpleWhiteboardManager for managing whiteboards

 






 

 


  Review Request #886
  —
  Created Aug. 7, 2021 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Create PurpleWhiteboardManager for managing whiteboards

 








  


 
 

  
Compiled only. Tried to create a silc account, but it dies deep in libsilc.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Create PurpleWhiteboardManager for managing whiteboards


    		
    c1fb08b0f3ebf8b8a15cba71ae2fec3a6dec35e3

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
This might not be an issue, but does obj need to be freed when we're done with it? Maybe that's …

      		
      
       jrchampjrchamp
      
      
       
      
     




     

      
       
       
Do you not need to add it to the manager now? And somewhere throw in some cleanup.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Extra space.

      		
      
       QuLogicQuLogic
      
      
       
      
     


    

 There are no open issues


   

  

 







 






  

 








 














 





 

  

   




jrchamp




   

   







  

 



 

  


   

   

    
 
jrchamp


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       libpurple/purplewhiteboardmanager.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    This might not be an issue, but does obj need to be freed when we're done with it? Maybe that's being handled by the manager, but I wasn't sure if this was creating a new copy of the object. I was reading the documentation and was not sure: https://docs.gtk.org/gio/method.ListModel.get_item.html
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Wow do the new docs suck.. The old docs say it's transfer-full so we have a reference, so we just need to make sure we're telling our callers their responsible for it as right now we're claiming transfer-none.  Also I'm not sure if we should g_clear_object when it's not a PurpleWhiteboard but we can probably add that to be safe.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Sorry, I was looking at both methods and it looks like I linked to the other one. Here's g_list_model_get_object: https://docs.gtk.org/gio/method.ListModel.get_object.html
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       libpurple/protocols/silc/wb.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Do you not need to add it to the manager now? And somewhere throw in some cleanup.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       libpurple/protocols/silc/wb.c
       


        (Diff revisions 2 - 3)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Extra space.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  

















  

 









     

    

   

  

  

   
   Loading...