Summary

Move the plugin state management from GPluginManager to GPluginLoader

Review Request #845 — Created July 27, 2021 and submitted July 30, 2021, 3:40 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Commit

a6f76fb4d7bf

Reviewers

Groups

pidgin

People

Description

Move the plugin state management from GPluginManager to GPluginLoader

Testing Done

Ran unit tests

Issues

Description	From	Last Updated
For klass and klass->query above, the code was modified to check against NULL. Here in load and below in unload, …	jrchamp	July 28, 2021, 5:22 p.m.

gplugin/gplugin-loader.c (Diff revision 1)

The issue has been resolved. Show all issues

For klass and klass->query above, the code was modified to check against NULL. Here in load and below in unload, it wasn't. I don't know enough to tell which is correct. I hope this is helpful.

grim July 28, 2021, 9:13 a.m.

Both work, but we're trying to be more explicit and add the NULL.

Commit:

3fd2bbd56e97

a6f76fb4d7bf

Diff:

Revision 2 (+102 -68)

Show changes

	gplugin/gplugin-loader.c
	gplugin/gplugin-manager.c

Ship it!

```
Ship It!
```

Status:: Completed