Move the plugin state management from GPluginManager to GPluginLoader

 






 

 


  Review Request #845
  —
  Created July 26, 2021 and submitted 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  gplugin/gplugin
 









 
 

  default
 









 
 

  
 









 
 

  
 









 
 

  a6f76fb4d7bf
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Move the plugin state management from GPluginManager to GPluginLoader

 








  


 
 

  
Ran unit tests

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
For klass and klass->query above, the code was modified to check against NULL. Here in load and below in unload, …

      		
      
       jrchampjrchamp
      
      
       
      
     


    

 There are no open issues


   

  

 







 






  

 








 














 





 

  

   




jrchamp




   

   







  

 



 

  


   

   

    
 
jrchamp


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       gplugin/gplugin-loader.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    For klass and klass->query above, the code was modified to check against NULL. Here in load and below in unload, it wasn't. I don't know enough to tell which is correct. I hope this is helpful.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Both work, but we're trying to be more explicit and add the NULL.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  

















  

 









     

    

   

  

  

   
   Loading...