Summary

Clean up PidginCredentialManager

Review Request #804 — Created July 12, 2021 and submitted July 18, 2021, 3:20 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

4942738e2b35

Groups

People

Description

* Remove the unnecessary _provider from a bunch of symbols
* Use g_task_return_new_error
* Some other minor cleanups

Testing Done

Compiled and ran the unit tests.

Issues

Description	From	Last Updated
Alignment looks a bit off, maybe some extra tabs.	QuLogic	July 18, 2021, 12:27 a.m.
Alignment again.	QuLogic	July 18, 2021, 12:27 a.m.
More alignment.	QuLogic	July 18, 2021, 12:27 a.m.
Re-align.	QuLogic	July 18, 2021, 12:29 a.m.

libpurple/purplecredentialmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Alignment looks a bit off, maybe some extra tabs.
```
libpurple/purplecredentialmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Alignment again.
```
libpurple/purplecredentialmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
More alignment.
```
libpurple/tests/test_credential_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Re-align.
```

Commit:

c1c14b304478

4942738e2b35

Diff:

Revision 2 (+153 -180)

	libpurple/core.c
	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialmanager.c
	libpurple/plugins/keyrings/secretservice.c
	libpurple/plugins/keyrings/wincred.c
	libpurple/plugins/keyrings/kwallet/purplekwallet.cpp
	libpurple/tests/test_credential_manager.c
	pidgin/prefs/pidgincredentialspage.c

Ship it!