Summary

Add description to PurpleProtocol

Review Request #803 — Created July 12, 2021 and submitted July 13, 2021, 8:25 p.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

d9af66569547

Groups

People

Description

Add description to PurpleProtocol

Testing Done

Ran and tested on the Account Assistant, which I'm developing currently.

Issues

Description	From	Last Updated
extra whitespace.	grim	July 12, 2021, 9:23 p.m.
extra whitespace	grim	July 12, 2021, 9:23 p.m.
Indentation looks off here.	grim	July 12, 2021, 9:23 p.m.
Looks like this just created a define but didn't actually set it when creating the protocol?	grim	July 12, 2021, 9:23 p.m.
indentation looks off here.	grim	July 12, 2021, 9:23 p.m.

Change Summary:: Remove the Issue number from the summary/description/testing as it's tagged so it'll end up in the commit message.
Summary:: Issue Fix 17460-Add description to PurpleProtocol
Add description to PurpleProtocol
Description:: ~
Issue Fix 17460-Add description to PurpleProtocol
~
Add description to PurpleProtocol
Testing Done:: ~
Issue Fix for PIDGIN-17460: Add description to PurpleProtocol
~
Add description to PurpleProtocol

Ran and tested on the Account Assistant, which I'm developing currently.

Change Summary:: one more tweak
Testing Done:: -
Add description to PurpleProtocol
-

Ran and tested on the Account Assistant, which I'm developing currently.

libpurple/protocol.c (Diff revision 1)
The issue has been resolved. Show all issues
```
extra whitespace.
```
libpurple/protocol.c (Diff revision 1)
The issue has been resolved. Show all issues
```
extra whitespace
```
libpurple/protocols/facebook/facebook.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Indentation looks off here.
```

libpurple/protocols/sametime/sametime.c (Diff revision 1)

The issue has been resolved. Show all issues

Looks like this just created a define but didn't actually set it when creating the protocol?

libpurple/protocols/silc/silc.c (Diff revision 1)
The issue has been resolved. Show all issues
```
indentation looks off here.
```

Change Summary:

Fixed the suggested changes - Add description to PurpleProtocol

Commit:

b24718271641

d9af66569547

Diff:

	libpurple/protocol.h
	libpurple/protocol.c
	libpurple/protocols/bonjour/bonjour.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/gg/gg.c
	libpurple/protocols/irc/irc.c
	libpurple/protocols/jabber/xmpp.c
	libpurple/protocols/novell/novell.c
	3 more

Ship it!

~		Issue Fix 17460-Add description to PurpleProtocol
	~	Add description to PurpleProtocol

~		Issue Fix for PIDGIN-17460: Add description to PurpleProtocol
	~	Add description to PurpleProtocol

		Ran and tested on the Account Assistant, which I'm developing currently.