Summary

Split PurplePluginInfo out to its own file

Review Request #684 — Created May 29, 2021 and submitted June 18, 2021, midnight

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

faaec828269f

Groups

People

Description

Split PurplePluginInfo out to its own file

Testing Done

Verified that plugins continued working.

Issues

Description	From	Last Updated
This is gone now, so I guess this might need a rebase.	QuLogic	June 17, 2021, 11:42 p.m.
In the original, there was a weird invisible space after convenience; not sure if it got copied here, but probably …	QuLogic	June 17, 2021, 11:43 p.m.
Can re-aligne this a bit.	QuLogic	June 17, 2021, 11:43 p.m.
Can combine these comments now.	QuLogic	June 17, 2021, 11:44 p.m.
Remove.	QuLogic	June 17, 2021, 11:44 p.m.
Remove.	QuLogic	June 17, 2021, 11:44 p.m.
Add braces.	QuLogic	June 17, 2021, 11:46 p.m.
Add braces.	QuLogic	June 17, 2021, 11:46 p.m.

Summary:: Split PurplePluginInfo out to it's own file
Split PurplePluginInfo out to its own file
Description:: ~
Split PurplePluginInfo out to it's own file
~
Split PurplePluginInfo out to its own file

libpurple/plugins.h (Diff revision 1)
The issue has been resolved. Show all issues
```
This is gone now, so I guess this might need a rebase.
```

libpurple/purpleplugininfo.h (Diff revision 1)

The issue has been resolved. Show all issues

In the original, there was a weird invisible space after convenience; not sure if it got copied here, but probably should check that.

checked it in hd looks like I didn't copy it somehow.

libpurple/purpleplugininfo.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Can re-aligne this a bit.
```
libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Can combine these comments now.
```
libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove.
```
libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove.
```
libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Add braces.
```
libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Add braces.
```

Commit:

8ef356952625

faaec828269f

Diff:

Revision 2 (+734 -611)

	doc/reference/libpurple/libpurple-docs.xml
	libpurple/meson.build
	libpurple/plugins.h
	libpurple/plugins.c
	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	po/POTFILES.in

Ship it!

~		Split PurplePluginInfo out to it's own file
	~	Split PurplePluginInfo out to its own file