Summary

Add back support for menu separators in the menus for plugin actions

Review Request #659 — Created May 18, 2021 and submitted May 25, 2021, 5:06 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

d8dde12687a0

Reviewers

Groups

pidgin

People

Description

Add back support for menu separators in the menus for plugin actions

Testing Done

Ran locally and verified the separator works from the Notitication Sound plugin under both Arc Darc and Adwaita themes.

Issues

Description	From	Last Updated
Is there a bug here, then? actions would never get updated, and this loop would be infinite.	QuLogic	May 25, 2021, 4:53 a.m.

pidgin/pidginpluginsmenu.c (Diff revision 1)

The issue has been resolved. Show all issues

Is there a bug here, then? actions would never get updated, and this loop would be infinite.

grim May 18, 2021, 8:29 a.m.
```
Apparently i missed a commit here...
```

grim May 18, 2021, 8:33 a.m.

Hah, I misread.. And yeah this is a bug. It looks like the original behavior here was to look for an action with a lable of NULL to create a separator, but that's worthless as it allocates memory for nothing. So.. should we crash or g_assert_if_reached or what?

Commit:

f358c66ad74b

d8dde12687a0

Diff:

Revision 2 (+16 -1)

Show changes

pidgin/pidginpluginsmenu.c

Ship it!

```
Ship It!
```

Status:: Completed