Summary

Separate the conversation commands out to their own file

Review Request #632 — Created April 30, 2021 and submitted May 7, 2021, 2:32 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

9fa6762b8942

Groups

People

Description

Separate the conversation commands out to their own file

Testing Done

Ran pidgin locally verified the commands worked. Ran ninja pidgin-doc as well as ninja pidgin-pot

Issues

Description	From	Last Updated
Should it be private then?	QuLogic	May 7, 2021, 1:36 a.m.
8	QuLogic	May 7, 2021, 1:36 a.m.
8	QuLogic	May 7, 2021, 1:36 a.m.
This should have been clearall:, I think.	QuLogic	May 7, 2021, 1:36 a.m.

Change Summary:

Readd libpurple/keyring.c to POTFILES.in as there's more keyring clean up that will be put into another rr.

Commit:

611278122fef

3fc554275c31

Diff:

Revision 2 (+286 -178)

	doc/reference/pidgin/pidgin-docs.xml
	pidgin/gtkconv.c
	pidgin/libpidgin.c
	pidgin/meson.build
	pidgin/pidgincommands.h
	pidgin/pidgincommands.c
	po/POTFILES.in

pidgin/pidgincommands.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Should it be private then?
```
pidgin/pidgincommands.c (Diff revision 2)
The issue has been resolved. Show all issues
```
8
```
pidgin/pidgincommands.c (Diff revision 2)
The issue has been resolved. Show all issues
```
8
```

pidgin/pidgincommands.c (Diff revision 2)

The issue has been resolved. Show all issues

This should have been clearall:, I think.

yikes, how long has that been broken then.. I don't think I edited any of the code :-D

Commit:

3fc554275c31

9fa6762b8942

Diff:

Revision 3 (+277 -179)

	doc/reference/pidgin/pidgin-docs.xml
	pidgin/gtkconv.c
	pidgin/libpidgin.c
	pidgin/meson.build
	pidgin/pidgincommands.c
	pidgin/pidginprivate.h
	po/POTFILES.in

Ship it!