Fix a number of issues with the windows build

Review Request #593 — Created April 3, 2021 and submitted

Information

pidgin/pidgin
release-2.x.y
c7d00fce867f

Reviewers

Fix a number of issues with the windows build

  • Standardize on wprintf in pidgin/win32/winpidgin.c
  • Use the inetc nsis plugin that supports https
  • If building under msys2 copy libgcc_s_dw2-1.dll and libwinpthread to the
    install directory.

Ran successfully from the

  • install directory
  • online installer
  • offline installer
  • portable zip file

Description From Last Updated

The latter line is if you end up larger than the size of the buffer. Adding a \0 to the …

QuLogicQuLogic
grim
grim
grim
QuLogic
  1. 
      
  2. pidgin/win32/winpidgin.c (Diff revision 4)
     
     
     
    Show all issues

    The latter line is if you end up larger than the size of the buffer. Adding a \0 to the format string is not going to fix that.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
grim
Review request changed
Status:
Completed