bleh I knew something like this existed but I forgot to check.. sorry about that.

I think there was more to this before and I didn't clean it up well..

we should probably cancel everything yeah..

Sorry, I might walk this back a bit; it looks like close is called when externally closed too. Do we want to cancel everything in that case? Or should we wait for a re-open attempt?

If we don't accounts will be in a limbo state until another task causes us to process the queue.  If we wanted to leave those open then we'd need to add a timeout or something to attempt to process the queue again.

Right, makes sense.

that's a good call.

good catch

This is to deal with g_warnings for subclasses not implementing it.

What's going to trigger the warning? GObject?

So I guess I'm confusing the warning from unimplemented functions for GInterface with this.  I threw together the following proof of concept and there were no warnings...

#include <glib.h>
#include <glib-object.h>

G_DECLARE_DERIVABLE_TYPE(TestAbstract, test_abstract, TEST, ABSTRACT, GObject)

struct _TestAbstractClass {
    GObjectClass parent;

    void (*somefunc)(TestAbstract *abstract);
};

G_DEFINE_ABSTRACT_TYPE(TestAbstract, test_abstract, G_TYPE_OBJECT)

static void
test_abstract_somefunc(TestAbstract *abstract) {
    TestAbstractClass *klass = TEST_ABSTRACT_GET_CLASS(abstract);

    if(klass != NULL && klass->somefunc) {
        klass->somefunc(abstract);
    }
}

static void
test_abstract_init(TestAbstract *t) {
}

static void
test_abstract_class_init(TestAbstractClass *klass) {
}

G_DECLARE_FINAL_TYPE(TestConcrete, test_concrete, TEST, CONCRETE, TestAbstract);

struct _TestConcrete {
    TestAbstract parent;
};

G_DEFINE_TYPE(TestConcrete, test_concrete, test_abstract_get_type())

static void
test_concrete_init(TestConcrete *t) {
}

static void
test_concrete_class_init(TestConcreteClass *klass) {
}

gint
main(gint argc, gchar *argv[]) {
    GObject *obj = g_object_new(test_concrete_get_type(), NULL);

    test_abstract_somefunc(TEST_ABSTRACT(obj));

    return 0;
}

fixed in another pr.

fixed in another pr.