Summary

Add a description to PurpleCredentialProvider and show it in the preferences selector

Review Request #539 — Created Feb. 27, 2021 and submitted Feb. 27, 2021, 6:03 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

0db0fac7486e

Reviewers

Groups

pidgin

People

Description

Add a description to PurpleCredentialProvider and show it in the preferences selector

Testing Done

Compiled and ran locally.

Files

Issues

Description	From	Last Updated
should	QuLogic	Feb. 27, 2021, 3:20 p.m.
Is it really 10 characters? Your screenshots don't seem to be wrapped that short.	QuLogic	Feb. 27, 2021, 3:20 p.m.

pidgin/pidgincredentialproviderstore.h (Diff revision 1)
The issue has been resolved. Show all issues
```
should
```

pidgin/pidgincredentialspage.c (Diff revision 1)

The issue has been resolved. Show all issues

Is it really 10 characters? Your screenshots don't seem to be wrapped that short.

grim Feb. 27, 2021, 12:21 p.m.

Bleh I ment to move this back to 40.. The VV prefs make the window huge so this is stupidly hard to test right now, and even then, the cell view gets weird. but with 40 it seemed okayish. We still need to redesign this window or at least put it in glade, but with this at 40 characters it at least stops the window from growing more (I had a really long description to verify during testing).

Commit:

485350428a34

0db0fac7486e

Diff:

Revision 2 (+110 -7)

Show changes

	libpurple/purplecredentialprovider.h
	libpurple/purplecredentialprovider.c
	libpurple/purplenoopcredentialprovider.c
	libpurple/plugins/keyrings/secretservice.c
	libpurple/plugins/keyrings/wincred.c
	pidgin/pidgincredentialproviderstore.h
	pidgin/pidgincredentialproviderstore.c
	pidgin/pidgincredentialspage.c
	1 more

Ship it!

```
Ship It!
```

Status:: Completed