Summary

Fix some issues with the protocol chooser and clean up its usage in GtkAccount

Review Request #533 — Created Feb. 26, 2021 and submitted Feb. 27, 2021, 12:17 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17471, PIDGIN-17491, PIDGIN-17495

Depends On

Commit

e19cd8097c0a

Reviewers

Groups

pidgin

People

Description

Fix some issues with the protocol chooser and clean up its usage in GtkAccount

Added PidginProtocolStore and PidginProtocolChooser to the Glade catalog.
Updated the template for PidginProtocolChooser to use a GtkTreeModelSort to sort the list of protocols.
Ported the existing purple_protocols_* API use to pidgin_protocol_manager_*

Testing Done

Verified the new account dialog shows up properly with the protocol chooser sorted.
Verified that editing an account had the proper protocol selected.
Verified that changing a protocol on an existing account worked.

Bugs:: PIDGIN-17495

Change Summary:: Found this other bug that I forgot about while triaging, and turns out this does fix it :)
Bugs:: PIDGIN-17491

Summary:: Fix some issues with the protocol chooser and clean up it's usage in GtkAccount
Fix some issues with the protocol chooser and clean up its usage in GtkAccount
Description:: ~
Fix some issues with the protocol chooser and clean up it's usage in GtkAccount
~
Fix some issues with the protocol chooser and clean up its usage in GtkAccount

~
Added PidginProtocolStore and PidginProtocolChooser to the Glade catalog.
~ Updated the template for PidginProtocolChooser to use a GtkTreeModelSort to sort the list of protocols.
~
Added PidginProtocolStore and PidginProtocolChooser to the Glade catalog.
~ Updated the template for PidginProtocolChooser to use a GtkTreeModelSort to sort the list of protocols.
Ported the existing purple_protocols_* API use to pidgin_protocol_manager_*

Ship it!

```
Ship It!
```

Status:: Completed

~		Fix some issues with the protocol chooser and clean up it's usage in GtkAccount
	~	Fix some issues with the protocol chooser and clean up its usage in GtkAccount

~		Added PidginProtocolStore and PidginProtocolChooser to the Glade catalog.
~		Updated the template for PidginProtocolChooser to use a GtkTreeModelSort to sort the list of protocols.
	~	Added `PidginProtocolStore` and `PidginProtocolChooser` to the Glade catalog.
	~	Updated the template for `PidginProtocolChooser` to use a `GtkTreeModelSort` to sort the list of protocols.
		Ported the existing `purple_protocols_` API use to `pidgin_protocol_manager_`