Summary

Remove the GtkAlignment from PidginCredentialsPage as it's deprecated.

Review Request #484 — Created Feb. 7, 2021 and submitted Feb. 13, 2021, 12:39 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

ea44e1f49a10

Reviewers

Groups

pidgin

People

Description

Remove the GtkAlignment from PidginCredentialsPage as it's deprecated.

Testing Done

Compiled and ran locally. Note that glade 3.38 doesn't show the margin on load, but if you tweak the value you'll see that it does work.

Issues

Description	From	Last Updated
I didn't notice this on the original, but the padding is wrong on this page; compare with the Keyring page …	QuLogic	Feb. 13, 2021, 12:24 a.m.

The issue has been resolved. Show all issues

I didn't notice this on the original, but the padding is wrong on this page; compare with the Keyring page and there's more padding below the title, and after the label.

grim Feb. 12, 2021, 5:48 a.m.

Yeah the make frame thing adds a label with 4 spaces... I'm not sure how to account for that.

Commit:

36f6d69f45a0

ea44e1f49a10

Diff:

Revision 2 (+58 -40)

Show changes

pidgin/resources/Prefs/credentials.ui

Ship it!

```
Ship It!
```

Status:: Completed