Update buddy.c to more closely match our current gobject structure.

Review Request #473 — Created Feb. 2, 2021 and submitted

Information

pidgin/pidgin
default
3fa5f1527dcf

Reviewers

Update buddy.c to more closely match our current gobject structure.

Compiled and ran pidgin locally.

Description From Last Updated

!=, not =.

QuLogicQuLogic

No need for == TRUE on a boolean.

QuLogicQuLogic

Same for blist here.

QuLogicQuLogic

Going offline checks if this is 0, not 1.

QuLogicQuLogic

This previously used purple_blist_get_handle, not purple_blist_get_default.

QuLogicQuLogic

Extra trailing newline.

QuLogicQuLogic

Here's another that's not get_default.

QuLogicQuLogic

And another.

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/buddy.c (Diff revision 1)
     
     
    Show all issues

    !=, not =.

  3. libpurple/buddy.c (Diff revision 1)
     
     
    Show all issues

    No need for == TRUE on a boolean.

  4. libpurple/buddy.c (Diff revision 1)
     
     
     
     
     
    Show all issues

    Same for blist here.

  5. libpurple/buddy.c (Diff revision 1)
     
     
    Show all issues

    Going offline checks if this is 0, not 1.

  6. libpurple/buddy.c (Diff revision 1)
     
     
    Show all issues

    This previously used purple_blist_get_handle, not purple_blist_get_default.

  7. libpurple/buddy.c (Diff revision 1)
     
     
    Show all issues

    Extra trailing newline.

  8. 
      
grim
QuLogic
  1. 
      
  2. libpurple/buddy.c (Diff revision 2)
     
     
    Show all issues

    Here's another that's not get_default.

  3. libpurple/buddy.c (Diff revision 2)
     
     
    Show all issues

    And another.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed