Greatly simplify the nick color generation and properly detect dark themes.

Review Request #423 — Created Jan. 14, 2021 and submitted

Information

pidgin/pidgin
default
d54094135ed2

Reviewers

Instead of randomly adjusting colors based on some seed colors we now hash a user's name and use the first 2 bytes of the digest to determine the hue to color their nick. We then adjust it according to the background color.

This isn't perfect as you can see in the screen shot, but there are some tweaks we can do later to account for that. I skipped them for now as this gets us 90% of the way there with like 50% of the work.

Compiled and ran locally with Adwaita, Adwaita-Dark, and Arc-Dark themes.


Description From Last Updated

finesse

QuLogicQuLogic

Gets

QuLogicQuLogic
rekkanoryo
  1. Ship It!
  2. 
      
QuLogic
  1. Ship It!
  2. pidgin/gtkconv.c (Diff revision 1)
     
     
    Show all issues

    finesse

  3. pidgin/pidginstylecontext.h (Diff revision 1)
     
     
    Show all issues

    Gets

  4. 
      
grim
grim
Review request changed
Status:
Completed