Summary

Port the secretservice keyring to PurpleCredentialProvider

Review Request #401 — Created Jan. 5, 2021 and submitted Jan. 26, 2021, 7:40 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

fe3c6d2e6362

Reviewers

Groups

pidgin

People

Description

Port the secret service keyring to PurpleCredentialProvider

Testing Done

Made sure passwords were created and deleted in seahorse.

Issues

Description	From	Last Updated
If you pass the callback over here directly, then do you not get the wrong source_object in the GAsyncReadyCallback?	QuLogic	Jan. 26, 2021, 5:48 a.m.
Are these spaces?	QuLogic	Jan. 26, 2021, 6:29 a.m.
were	QuLogic	Jan. 26, 2021, 6:29 a.m.
purple_debug?	QuLogic	Jan. 26, 2021, 6:29 a.m.

Change Summary:

removed the account from the _finish methods.

Commit:

ffb288c4f5ca

cd860e914033

Diff:

Revision 2 (+149 -255)

Show changes

libpurple/plugins/keyrings/secretservice.c

libpurple/plugins/keyrings/secretservice.c (Diff revision 2)

The issue has been resolved. Show all issues

If you pass the callback over here directly, then do you not get the wrong source_object in the GAsyncReadyCallback?

grim Jan. 24, 2021, 11:41 a.m.
```
crap...
```

Change Summary:

Correctly proxy the GAsyncResults and make sure the provider gets set as active.

Testing Done:

~		The plugin loads and unloads successfully but there's no way to select it to actually test it right now.
	~	Made sure passwords were created and deleted in seahorse.

Commit:

cd860e914033

a48915f4e3aa

Diff:

Revision 3 (+261 -242)

Show changes

	libpurple/core.c
	libpurple/purplecredentialmanager.c
	libpurple/plugins/keyrings/secretservice.c

Change Summary:

mark the secretservice plugin as autoload.

Commit:

a48915f4e3aa

0e03ee2aaa47

Diff:

Revision 4 (+263 -243)

Show changes

	libpurple/core.c
	libpurple/purplecredentialmanager.c
	libpurple/plugins/keyrings/secretservice.c

libpurple/plugins/keyrings/secretservice.c (Diff revision 4)
The issue has been resolved. Show all issues
```
Are these spaces?
```
libpurple/purplecredentialmanager.c (Diff revision 4)
The issue has been resolved. Show all issues
```
were
```
libpurple/purplecredentialmanager.c (Diff revision 4)
The issue has been resolved. Show all issues
```
purple_debug?
```

Commit:

0e03ee2aaa47

fe3c6d2e6362

Diff:

Revision 5 (+265 -243)

Show changes

	libpurple/core.c
	libpurple/purplecredentialmanager.c
	libpurple/plugins/keyrings/secretservice.c

Ship it!

```
Ship It!
```

Status:: Completed