This change has been marked as completed.

Describe the completed change (optional):

Summary

Update Pidgin.Message to honor Purple.Message:attributes

Review Request #3938 — Created March 28, 2025 and submitted 5 days, 1 hour ago

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3937~~

Groups

People

Description*

This should automatically format messages based on the attributes.

Testing Done

Connected to a test irc network and verified that messages looked like they should.

Commits

Summary	ID
Update Pidgin.Message to honor Purple.Message:attributes This should automatically format messages based on the attributes.	df1073aca1489e1aeb31ece96b2107dc0a250737

Issues

Description	From	Last Updated
This means that the PurpleMessage::attributes list will be modified below if it's an action/event, even though that's a Pidgin-specific formatting.	QuLogic	5 days, 2 hours ago
There are no open issues

pidgin/pidginmessage.c (Diff revision 1)

The issue has been resolved. Show all issues

This means that the PurpleMessage::attributes list will be modified below if it's an action/event, even though that's a Pidgin-specific formatting.

Good call, we need to return a reference anyways, so we lose nothing by making a copy which would leave the purple message untouched.

Change Summary:

Use a copy of the attrs from the message as we need to return a ref anyways and this leaves the purple message untouched.

Commits:

	Summary	ID
	Update Pidgin.Message to honor Purple.Message:attributes This should automatically format messages based on the attributes.	71729b1e29f71c10ddc5c4e4a6d532741597d809
	Update Pidgin.Message to honor Purple.Message:attributes This should automatically format messages based on the attributes.	df1073aca1489e1aeb31ece96b2107dc0a250737

Diff:

Ship it!