Add a badges-changed signal to Purple.ConversationMember and fix the items changed emissions

 






 

 


  Review Request #3919
  —
  Created March 21, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  PIDGIN-18045
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This was added to make sure badge change are notified in the list model.


We now also pass 1 for removed and added to g_list_model_items_changed to notify when an item has changed. This feels weird, but GtkSortListModel and probably others, early return if removed and added are 0.

 








  


 
 

  
Ran the tests under valgrind and called in the turtles.

 







 









 





  








 




 







   

    
    
Diff Revision 3 (Latest)



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add a badges-changed signal to Purple.ConversationMember
     
This was added to try and get users sorted correctly in the conversation
member list, but there's some other issues up on the gtk side.

    

   
  		
  c2da8f13c0c41f4eb84920942a30acb1bc95ef25
  Gary Kramlich
 




    


    
    

   

  

 









 

  

   
    

     
      
      libpurple/purplebadges.c
     
    

   
  

 



 

  

   
    

     
      
      libpurple/purpleconversationmember.c
     
    

   
  

 



 

  

   
    

     
      
      libpurple/purpleconversationmembers.c
     
    

   
  

 



 

  

   
    

     
      
      libpurple/tests/test_conversation_member.c
     
    

   
  

 



 

  

   
    

     
      
      libpurple/tests/test_conversation_members.c
     
    

   
  

 










     

    

   

  

  

   
   Loading...