Add a badges-changed signal to Purple.ConversationMember and fix the items changed emissions

Review Request #3919 — Created March 21, 2025 and submitted

Information

pidgin/pidgin
default

Reviewers

This was added to make sure badge change are notified in the list model.

We now also pass 1 for removed and added to g_list_model_items_changed to notify when an item has changed. This feels weird, but GtkSortListModel and probably others, early return if removed and added are 0.

Ran the tests under valgrind and called in the turtles.

Summary ID
Add a badges-changed signal to Purple.ConversationMember
This was added to try and get users sorted correctly in the conversation member list, but there's some other issues up on the gtk side.
c2da8f13c0c41f4eb84920942a30acb1bc95ef25
Description From Last Updated

Should there be a Callbacks comment above here?

QuLogicQuLogic

s/ a / /

QuLogicQuLogic

s/typing-state/badges-changed/

QuLogicQuLogic
There are no open issues
grim
QuLogic
  1. 
      
  2. libpurple/purpleconversationmember.c (Diff revision 2)
     
     
     
    Show all issues

    Should there be a Callbacks comment above here?

  3. libpurple/purpleconversationmembers.c (Diff revision 2)
     
     
    Show all issues

    s/ a / /

  4. Show all issues

    s/typing-state/badges-changed/

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed
Loading...