This change has been marked as completed.

Describe the completed change (optional):

Summary

Rework HiyaService to include its endpoint

Review Request #3914 — Created March 18, 2025 and submitted 2 weeks, 1 day ago

Information

Owner

grim*

Repository

hiya/hiya

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description*

The initial design here over looked that each service belongs to an interface
and a protocol. This means that the services only have single endpoint and
thus our design needed to be updated.

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Rework HiyaService to include its endpoint The initial design here over looked that each service belongs to an interface and a protocol. This means that the services only have single endpoint and thus our design needed to be updated.	20aa28d963b6fbe51e65cd19288d159ddfb89d41

Issues

Description	From	Last Updated
*its	ivanhoe	2 weeks, 1 day ago
s/is/if	ivanhoe	2 weeks, 1 day ago
by the backends?	ivanhoe	2 weeks, 1 day ago
There are no open issues

Change Summary:

fix a warning I overlooked

Commits:

	Summary	ID
	Rework HiyaService to include its endpoint The initial design here over looked that each service belongs to an interface and a protocol. This means that the services only have single endpoint and thus our design needed to be updated.	2ae372ccf00aa9b721b0ad66fc0a286b86683d0d
	Rework HiyaService to include its endpoint The initial design here over looked that each service belongs to an interface and a protocol. This means that the services only have single endpoint and thus our design needed to be updated.	1ec1f5fef7498a31f4f0d0b475d40769e216b843

Diff:

Revision 2 (+890 -1008)

Show changes

	hiya/hiyaendpoint.h
	hiya/hiyaendpoint.c
	hiya/hiyaprotocol.h
	hiya/hiyaservice.h
	hiya/hiyaservice.c
	hiya/meson.build
	hiya/tests/meson.build
	hiya/tests/test_backend.c
	2 more

hiya/hiyaservice.h (Diff revision 2)
The issue has been resolved. Show all issues
```
*its
```
hiya/hiyaservice.h (Diff revision 2)
The issue has been resolved. Show all issues
```
s/is/if
```
hiya/hiyaservice.h (Diff revision 2)
The issue has been resolved. Show all issues
```
by the backends?
```

Change Summary:

address issues

Commits:

	Summary	ID
	Rework HiyaService to include its endpoint The initial design here over looked that each service belongs to an interface and a protocol. This means that the services only have single endpoint and thus our design needed to be updated.	1ec1f5fef7498a31f4f0d0b475d40769e216b843
	Rework HiyaService to include its endpoint The initial design here over looked that each service belongs to an interface and a protocol. This means that the services only have single endpoint and thus our design needed to be updated.	20aa28d963b6fbe51e65cd19288d159ddfb89d41

Diff:

Revision 3 (+890 -1008)

Show changes

	hiya/hiyaendpoint.h
	hiya/hiyaendpoint.c
	hiya/hiyaprotocol.h
	hiya/hiyaservice.h
	hiya/hiyaservice.c
	hiya/meson.build
	hiya/tests/meson.build
	hiya/tests/test_backend.c
	2 more

Ship it!

```
Ship It!
```

Status:: Completed

hiya/hiyaservice.h (Diff revision 2)

hiya/hiyaservice.h (Diff revision 2)

hiya/hiyaservice.h (Diff revision 2)