This change has been marked as completed.

Describe the completed change (optional):

Summary

The start of the backend class

Review Request #3911 — Created March 16, 2025 and submitted 2 weeks, 1 day ago

Information

Owner

grim*

Repository

hiya/hiya

Branch

default

Bugs

Depends On

Blocks

3912

Reviewers

Groups

pidgin

People

Description*

The start of the backend class

Testing Done

Ran the unit tests under valgrind and called in the turtles.

Commits

Summary	ID
The start of the backend class	9ed65defc17291d53c20fa4f9e9a3e835aa6893d

Issues

Description	From	Last Updated
The doesn't seems superfluous.	ivanhoe	2 weeks, 2 days ago
The doesn't seems superfluous.	ivanhoe	2 weeks, 2 days ago
Does data not count towards the n_params parameter of g_signal_new_class_handler?	ivanhoe	2 weeks, 2 days ago
Same question as on line 103.	ivanhoe	2 weeks, 2 days ago
Should add "if true" in front of "browse" here.	ivanhoe	2 weeks, 2 days ago
That seems like a weird way to set up the Enum. If it's intended to be like that, a comment …	ivanhoe	2 weeks, 2 days ago
There are no open issues

Change Summary:

Add signals and properties and add an error parameter to the service discovery vfuncs

Commits:

	Summary	ID
	The start of the backend class	c32f530ce21b81e12e118b1ba01c93cbf7862fca
	The start of the backend class	edc0d71b5ddce20adbb4b68cb16fdc1626b3aabd

Diff:

Revision 2 (+1252)

Show changes

	hiya/hiyabackend.h
	hiya/hiyabackend.c
	hiya/meson.build
	hiya/tests/meson.build
	hiya/tests/test_backend.c

hiya/hiyabackend.c (Diff revision 2)
The issue has been resolved. Show all issues
```
The doesn't seems superfluous.
```
hiya/hiyabackend.c (Diff revision 2)
The issue has been resolved. Show all issues
```
The doesn't seems superfluous.
```

hiya/hiyabackend.c (Diff revision 2)

The issue has been dropped. Show all issues

Does data not count towards the n_params parameter of g_signal_new_class_handler?

grim 2 weeks, 2 days ago

Every signal callback gets a data object that is the value of data passed to g_signal_connect and is not counted as part of the signal definitition per g_signal_new*.

hiya/hiyabackend.c (Diff revision 2)
The issue has been dropped. Show all issues
```
Same question as on line 103.
```
hiya/hiyabackend.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Should add "if true" in front of "browse" here.
```

hiya/tests/test_backend.c (Diff revision 2)

The issue has been dropped. Show all issues

That seems like a weird way to set up the Enum. If it's intended to be like that, a comment with the reasoning would be nice.

grim 2 weeks, 2 days ago

The testbackend has no properties right now, but is overriding properties from the parent class. The property at index 0 is reserved, hence the PROP_0, but to keep things consistent in the code you set the first overridden property to the value of N_PROPERTIES. See the gplugin python plugin code for a more complete example https://keep.imfreedom.org/gplugin/gplugin/file/65b765ccd0b4/python3/gplugin-python3-plugin.c#l45.

Change Summary:

address issues

Commits:

	Summary	ID
	The start of the backend class	edc0d71b5ddce20adbb4b68cb16fdc1626b3aabd
	The start of the backend class	9ed65defc17291d53c20fa4f9e9a3e835aa6893d

Diff:

Revision 3 (+1252)

Show changes

	hiya/hiyabackend.h
	hiya/hiyabackend.c
	hiya/meson.build
	hiya/tests/meson.build
	hiya/tests/test_backend.c

Ship it!

```
Ship It!
```

Status:: Completed