Add Ibis.Feature.get_prefix_for_mode

Review Request #3901 — Created March 14, 2025 and submitted

Information

ibis/ibis
default

Reviewers

This will make it easier for users to keep prefixes consistent. This also
implements Ibis.Client.get_prefix_for_mode as well.

Ran the tests under valgrind and called in the turtles.

Summary ID
Add Ibis.Feature.get_prefix_for_mode
This will make it easier for users to keep prefixes consistent. This also implements Ibis.Client.get_prefix_for_mode as well.
7f96aab502e143d2ee7e973b7504a5df6a6b5018
Description From Last Updated

Shouldn't there be a length and/or null check for prefixes?

ivanhoeivanhoe

s/network/networks

ivanhoeivanhoe
ivanhoe
  1. 
      
  2. ibis/ibisfeatures.c (Diff revision 1)
     
     
    Show all issues

    Shouldn't there be a length and/or null check for prefixes?

    1. it shouldn't ever not match but I'm not sure that we have tests for that. That said, I have no issue adding a bounds check here.

  3. ibis/ibisfeatures.h (Diff revision 1)
     
     
    Show all issues

    s/network/networks

  4. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed