Summary

Add Ibis.Feature.get_prefix_for_mode

Review Request #3901 — Created March 14, 2025 and submitted March 14, 2025, 12:58 a.m.

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Blocks

3900

Groups

People

Description

This will make it easier for users to keep prefixes consistent. This also
implements Ibis.Client.get_prefix_for_mode as well.

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Add Ibis.Feature.get_prefix_for_mode This will make it easier for users to keep prefixes consistent. This also implements Ibis.Client.get_prefix_for_mode as well.	7f96aab502e143d2ee7e973b7504a5df6a6b5018

Issues

Description	From	Last Updated
Shouldn't there be a length and/or null check for prefixes?	ivanhoe	March 14, 2025, 12:55 a.m.
s/network/networks	ivanhoe	March 14, 2025, 12:55 a.m.

ibis/ibisfeatures.c (Diff revision 1)

The issue has been resolved. Show all issues

Shouldn't there be a length and/or null check for prefixes?

it shouldn't ever not match but I'm not sure that we have tests for that. That said, I have no issue adding a bounds check here.

ibis/ibisfeatures.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/network/networks
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Add Ibis.Feature.get_prefix_for_mode This will make it easier for users to keep prefixes consistent. This also implements Ibis.Client.get_prefix_for_mode as well.	a4f41a85e5264c993e08ad68ac7ef1a9804c0e83
	Add Ibis.Feature.get_prefix_for_mode This will make it easier for users to keep prefixes consistent. This also implements Ibis.Client.get_prefix_for_mode as well.	7f96aab502e143d2ee7e973b7504a5df6a6b5018

Diff:

Ship it!

Ship it!