Implement message notifications is a hacky way

Review Request #3897 — Created March 11, 2025 and submitted

Information

pidgin/pidgin
default

Reviewers

This should get cleaned up when Purple.History exists, but this feels an
immediate need even if it's a little hacky/buggy.

Sent some messages via IRCv3 and made sure they were cleared when the conversation was focused.

Summary ID
Implement message notifications is a hacky way
This should get cleaned up when Purple.History exists, but this feels an immediate need even if it's a little hacky/buggy.
690e1d66c5455069a083c17f9bae515cfd782020
Description From Last Updated

The 2nd part of the condition seems superfluous. If something greater 0 is substracted from current the resulting value should …

ivanhoeivanhoe

s/show/map

ivanhoeivanhoe
ivanhoe
  1. 
      
  2. pidgin/pidginconversation.c (Diff revision 1)
     
     
    Show all issues

    The 2nd part of the condition seems superfluous. If something greater 0 is substracted from current the resulting value should always be less than current.

    Also I'm wondering what the purpose of the condition is in general. removed is an unsigned int so it shouldn't be negative and there would be no harm in adding 0 to current if removed is 0.

    1. It's to avoid an underflow as it's an unsigned integer. That said, we're not removing messages right now anyways, so we can just skip all of this.

  3. pidgin/pidginconversation.c (Diff revision 1)
     
     
    Show all issues

    s/show/map

  4. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed