Summary

Implement message notifications is a hacky way

Review Request #3897 — Created March 11, 2025 and submitted March 11, 2025, 9:11 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3885~~

Reviewers

Groups

pidgin

People

Description

This should get cleaned up when Purple.History exists, but this feels an
immediate need even if it's a little hacky/buggy.

Testing Done

Sent some messages via IRCv3 and made sure they were cleared when the conversation was focused.

Commits

Summary	ID
Implement message notifications is a hacky way This should get cleaned up when Purple.History exists, but this feels an immediate need even if it's a little hacky/buggy.	690e1d66c5455069a083c17f9bae515cfd782020

Issues

Description	From	Last Updated
The 2nd part of the condition seems superfluous. If something greater 0 is substracted from current the resulting value should …	ivanhoe	March 11, 2025, 7:23 p.m.
s/show/map	ivanhoe	March 11, 2025, 7:23 p.m.

pidgin/pidginconversation.c (Diff revision 1)

The issue has been resolved. Show all issues

The 2nd part of the condition seems superfluous. If something greater 0 is substracted from current the resulting value should always be less than current.

Also I'm wondering what the purpose of the condition is in general. removed is an unsigned int so it shouldn't be negative and there would be no harm in adding 0 to current if removed is 0.

grim March 11, 2025, 6:20 p.m.

It's to avoid an underflow as it's an unsigned integer. That said, we're not removing messages right now anyways, so we can just skip all of this.

pidgin/pidginconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/show/map
```

Change Summary:

Address issues.

Commits:

	Summary	ID
	Implement message notifications is a hacky way This should get cleaned up when Purple.History exists, but this feels an immediate need even if it's a little hacky/buggy.	b4cb09c0466bae2a70ecf5558cf5eda4a11cb0c4
	Implement message notifications is a hacky way This should get cleaned up when Purple.History exists, but this feels an immediate need even if it's a little hacky/buggy.	690e1d66c5455069a083c17f9bae515cfd782020

Diff:

Revision 2 (+246 -2)

Show changes

	pidgin/pidginconversation.c
	pidgin/pidgindisplayitem.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed