Summary

Implement batching in Ibis.Client

Review Request #3894 — Created March 9, 2025 and submitted March 13, 2025, 7:01 p.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-52

Depends On

~~3892~~, ~~3891~~

Reviewers

Groups

pidgin

People

Description

Implement batching in Ibis.Client

Testing Done

Connected to my local ergo, joined a channel, and then asked for the channel history to verify that the batch capability was negotiated and that the channel history was sent as a batch.

A full output of the connection from ibis-cli is available on IBIS-52.

Commits

Summary	ID
Implement batching in Ibis.Client	d076a20217c7f46e9d18ef9a92475da004f2d3a2

Issues

Description	From	Last Updated
Every execution path of this function returns TRUE. Is this correct?	ivanhoe	March 12, 2025, 9:05 p.m.
s/have/has	ivanhoe	March 12, 2025, 9:05 p.m.
Looks like there's a word missing here. Maybe "of the batch"?	ivanhoe	March 12, 2025, 9:05 p.m.

ibis/ibisclient.c (Diff revision 1)

The issue has been resolved. Show all issues

Every execution path of this function returns TRUE. Is this correct?

grim March 12, 2025, 8:36 p.m.

That looks like a left over from the signal returning a boolean, and I never cleaned it up.

ibis/ibisclient.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/have/has
```
ibis/ibisclient.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Looks like there's a word missing here. Maybe "of the batch"?
```

Change Summary:

address issues

Commits:

	Summary	ID
	Implement batching in Ibis.Client	7c84503b4e53fba4790baf40aaebc8c0c312e4ad
	Implement batching in Ibis.Client	d076a20217c7f46e9d18ef9a92475da004f2d3a2

Diff:

Revision 2 (+336 -10)

Show changes

ibis/ibisclient.c

Ship it!

```
Ship It!
```

Status:: Completed