Summary

Add basic support for libspelling

Review Request #3850 — Created Feb. 21, 2025 and submitted Feb. 21, 2025, 6:04 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-18054

Depends On

Reviewers

Groups

pidgin

People

Description

This does the bare minimum to implement libspelling to get things going.

Testing Done

Built locally as well as the flatpak and verified that my horrible typing skills were pointed out.

Commits

Summary	ID
Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	d9ff94b218a2e66ab182a23d964d82d3675e3878

Issues

Description	From	Last Updated
Freebsd only has 0.2.1 and OpenBSD doens't have libspelling packaged so we'll need to add wraps for these.	grim	Feb. 21, 2025, 5:49 a.m.
Probably shouldn't split the Adwaita lines?	QuLogic	Feb. 21, 2025, 5:50 a.m.

The issue has been dropped. Show all issues

Freebsd only has 0.2.1 and OpenBSD doens't have libspelling packaged so we'll need to add wraps for these.

grim Feb. 21, 2025, 5:49 a.m.

So the wrap files don't work on FreeBSD or OpenBSD. FreeBSD ends up with an unresolved symbol in the docs and I'm not going to waste my time tracking that down. Also OpenBSD only has GTK 4.14.5 and libspelling has required GTK 4.15.5 since version 0.3.0 which was released 6 months ago.
So I think we're just going to let their builds fail for now.

Change Summary:

Add wrap files. These aren't tested yet, I'm putting them here so I can use rbt patch on the machines to test them.

Commits:

	Summary	ID
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	876775aef0390c6efc73e9f3fc4d5cd2cc9ebc8c
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	c4ba6afabf1e038a6d39cecb9292a22339b5fe9f

Diff:

Revision 2 (+94 -2)

Show changes

	im.pidgin.Pidgin3.yml
	meson.build
	pidgin/meson.build
	pidgin/pidginconversation.c
	pidgin/resources/Conversations/conversation.ui
	subprojects/gtksourceview5.wrap
	subprojects/libspelling.wrap

Change Summary:

fix the libspelling wrap file name and use libspelling 5.8.0 instead of the development 5.9.0

Commits:

	Summary	ID
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	c4ba6afabf1e038a6d39cecb9292a22339b5fe9f
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	486e6e18f780cd1be1087a7963b10cc2af723081

Diff:

Revision 3 (+94 -2)

Show changes

	im.pidgin.Pidgin3.yml
	meson.build
	pidgin/meson.build
	pidgin/pidginconversation.c
	pidgin/resources/Conversations/conversation.ui
	subprojects/gtksourceview5.wrap
	subprojects/libspelling-1.wrap

Change Summary:

fix the filename for gtksourceview-5.wrap

Commits:

	Summary	ID
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	486e6e18f780cd1be1087a7963b10cc2af723081
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	ae91ac94dc46b96015942edb55c0161074064642

Diff:

Revision 4 (+94 -2)

Show changes

	im.pidgin.Pidgin3.yml
	meson.build
	pidgin/meson.build
	pidgin/pidginconversation.c
	pidgin/resources/Conversations/conversation.ui
	subprojects/gtksourceview-5.wrap
	subprojects/libspelling-1.wrap

Change Summary:

move to gtksourceview 5.15.0

Commits:

	Summary	ID
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	ae91ac94dc46b96015942edb55c0161074064642
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	0c2c1f943a20b4d639506390dbf3ee1731c0ca1f

Diff:

Revision 5 (+94 -2)

Show changes

	im.pidgin.Pidgin3.yml
	meson.build
	pidgin/meson.build
	pidgin/pidginconversation.c
	pidgin/resources/Conversations/conversation.ui
	subprojects/gtksourceview-5.wrap
	subprojects/libspelling-1.wrap

Testing Done:: ~
Built locally as well as the flatpak and verified that my horrible typing skills we're pointed out.
~
Built locally as well as the flatpak and verified that my horrible typing skills were pointed out.

Change Summary:

move to gtksourceview 5.14.2 since 5.15.0 requires gtk 4.17.

Commits:

	Summary	ID
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	0c2c1f943a20b4d639506390dbf3ee1731c0ca1f
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	fccdb8fbb2280afb9cc3eefb66e8c1424ebde117

Diff:

Revision 6 (+94 -2)

Show changes

	im.pidgin.Pidgin3.yml
	meson.build
	pidgin/meson.build
	pidgin/pidginconversation.c
	pidgin/resources/Conversations/conversation.ui
	subprojects/gtksourceview-5.wrap
	subprojects/libspelling-1.wrap

meson.build (Diff revision 5)
The issue has been resolved. Show all issues
```
Probably shouldn't split the Adwaita lines?
```

Change Summary:

move the gi-docgen stuff before any other subprojects so our fallback can be used.
don't split the adwaita lines
add default_options to libspelling to disable sysprof

Commits:

	Summary	ID
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	fccdb8fbb2280afb9cc3eefb66e8c1424ebde117
	Add basic support for libspelling This does the bare minimum to implement libspelling to get things going.	d9ff94b218a2e66ab182a23d964d82d3675e3878

Diff:

Revision 7 (+134 -36)

Show changes

	im.pidgin.Pidgin3.yml
	meson.build
	pidgin/meson.build
	pidgin/pidginconversation.c
	pidgin/resources/Conversations/conversation.ui
	subprojects/gtksourceview-5.wrap
	subprojects/libspelling-1.wrap

Ship it!

```
Ship It!
```

Status:: Completed

meson.build (Diff revision 5)