Add find_or_create method to Purple.ContactManager
Review Request #3846 — Created Feb. 17, 2025 and updated
Add find_or_create method to Purple.ContactManager
Ran the unit test in valgrind.
Summary | ID |
---|---|
4626234658fd19a91332028e85aaead00479713b |
Description | From | Last Updated |
---|---|---|
this should probably use !purple_strempty |
|
|
Deleting this seems unnecessary |
|
|
There's no need for the [class@Pruple.Account] here its just redundant in the documentation. |
|
|
clear object or unref on the second one should be fine. |
|
|
reording this to the below should remove the need for the remove_all as that's just clearing the reference to the … |
|
|
This should be marked as (out) and (optional), not (nullable). |
|
|
Add g_assert_true(PURPLE_IS_CONTACT(contact1))? Right now they're just compared to each other, and could be NULL. |
|
-
-
-
-
-
-
reording this to the below should remove the need for the
remove_all
as that's just clearing the reference to the account that still exists in the manager. But if the manager is finalized first, it'll do its cleanup and unref the account as it should by itself.g_assert_finalize_object(manager); g_assert_finalize_object(account);

- Change Summary:
-
Addressed issues
- Commits:
-
Summary ID f230af143c4cce861b8607344ce0b3b5f8b378e4 4626234658fd19a91332028e85aaead00479713b