Summary

Implement Purple.ConversationMember.compare

Review Request #3845 — Created Feb. 17, 2025 and submitted Feb. 19, 2025, 1:53 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3844~~

Groups

People

Description

Implement Purple.ConversationMember.compare

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Implement Purple.ConversationMember.compare	3c3c972085ce6bffa6d33cba54e471007caa42b8

Issues

Description	From	Last Updated
It seems not right to set the nickname of member1 here. I think member2's nick should be set here.	ivanhoe	Feb. 19, 2025, 1:49 a.m.

libpurple/tests/test_conversation_member.c (Diff revision 1)

The issue has been resolved. Show all issues

It seems not right to set the nickname of member1 here. I think member2's nick should be set here.

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Implement Purple.ConversationMember.compare	302178f377706d272a0f844417b3867a055778d7
	Implement Purple.ConversationMember.compare	3c3c972085ce6bffa6d33cba54e471007caa42b8

Diff:

	libpurple/purpleconversationmember.h
	libpurple/purpleconversationmember.c
	libpurple/tests/test_conversation_member.c

Ship it!