Summary

IRCv3: Return an error when trying to join multiple channels at once

Review Request #3841 — Created Feb. 16, 2025 and submitted Feb. 18, 2025, 11:31 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-18044

Depends On

Reviewers

Groups

pidgin

People

Description

IRCv3 allows you to put names in like #channel1,#channel2 which works in

Pidgin 2 and other clients, but the

Purple.ProtocolConversations.join_channel_async function really only works for

a single channel and the channel join dialog was meant for a single channel.
So this solution isn't ideal, but it's better than creating a conversation

named #channel1,#channel2 at least for the time being.

Testing Done

Attempted to join #channel1,#channel2 and instead got the error message.

Commits

Summary	ID
IRCv3: Return an error when trying to join multiple channels at once IRCv3 allows you to put names in like `#channel1,#channel2` which works in Pidgin 2 and other clients, but the Purple.ProtocolConversations.join_channel_async function really only works for a single channel and the channel join dialog was meant for a single channel. So this solution isn't ideal, but it's better than creating a conversation named `#channel1,#channel2` at least for the time being.	45a06bb233fb5ac240dbceb4ccf9c6700c68ee2b

Summary

IRCv3: Return an error when trying to join multiple channels at once

IRCv3 allows you to put names in like `#channel1,#channel2` which works in Pidgin 2 and other clients, but the Purple.ProtocolConversations.join_channel_async function really only works for a single channel and the channel join dialog was meant for a single channel. So this solution isn't ideal, but it's better than creating a conversation named `#channel1,#channel2` at least for the time being.

45a06bb233fb5ac240dbceb4ccf9c6700c68ee2b

Issues

Description	From	Last Updated
The other error above doesn't have a trailing period; should this one?	QuLogic	Feb. 18, 2025, 10:52 p.m.

Change Summary:: Fix styling.
Description:: IRCv3 allows you to put names in like #channel1,#channel2 which works in
Pidgin 2 and other clients, but the
~ Purple.ProtocolConversations.join_channel_async function really only works for
~ Purple.ProtocolConversations.join_channel_async function really only works for
a single channel and the channel join dialog was meant for a single channel.

So this solution isn't ideal, but it's better than creating a conversation
named #channel1,#channel2 at least for the time being.

protocols/ircv3/purpleircv3protocolconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
The other error above doesn't have a trailing period; should this one?
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	IRCv3: Return an error when trying to join multiple channels at once IRCv3 allows you to put names in like `#channel1,#channel2` which works in Pidgin 2 and other clients, but the Purple.ProtocolConversations.join_channel_async function really only works for a single channel and the channel join dialog was meant for a single channel. So this solution isn't ideal, but it's better than creating a conversation named `#channel1,#channel2` at least for the time being.	c4ef1126271bc7df649bc113c0605eb9d79b724e
	IRCv3: Return an error when trying to join multiple channels at once IRCv3 allows you to put names in like `#channel1,#channel2` which works in Pidgin 2 and other clients, but the Purple.ProtocolConversations.join_channel_async function really only works for a single channel and the channel join dialog was meant for a single channel. So this solution isn't ideal, but it's better than creating a conversation named `#channel1,#channel2` at least for the time being.	45a06bb233fb5ac240dbceb4ccf9c6700c68ee2b

Diff:

Revision 2 (+20 -4)

Show changes

protocols/ircv3/purpleircv3protocolconversation.c

Ship it!

```
Ship It!
```

Status:: Completed

		IRCv3 allows you to put names in like `#channel1,#channel2` which works in
		Pidgin 2 and other clients, but the
~		Purple.ProtocolConversations.join_channel_async function really only works for
	~	`Purple.ProtocolConversations.join_channel_async` function really only works for
		a single channel and the channel join dialog was meant for a single channel.

		So this solution isn't ideal, but it's better than creating a conversation
		named `#channel1,#channel2` at least for the time being.