Summary

Create Birb.StringStream

Review Request #3840 — Created Feb. 16, 2025 and updated Feb. 18, 2025, 11:40 p.m.

Information

Owner

grim

Repository

birb/birb

Branch

default

Bugs

Depends On

3839

Reviewers

Groups

pidgin

People

Description

This is a simple Gio.InputStream that is backed by a GLib.String.

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Create Birb.StringStream This is a simple Gio.InputStream that is backed by a GLib.String.	5ebcf43193cb4bec8ab2bf79ecf8cd5a8bd1f3f3

Issues

Description	From	Last Updated
From the API as it is tested, I'm not really sure I see the difference here with GMemoryInputStream?	QuLogic	Feb. 18, 2025, 12:43 a.m.
A 0 return here (without input count of 0) should indicate EOF. That would imply the stream could not get …	QuLogic	Feb. 18, 2025, 12:43 a.m.

I'm not sure I have the read function implemented correctly. It works but https://docs.gtk.org/gio/method.InputStream.read.html says that 0 should only be returned if count is 0 or on EOF and we're not hitting either of those. Maybe we need to return an error with something like EAGAIN but I can't seem to find an error message for that.
I also skipped implementing/testing closing the stream and skipping bytes, but not sure we actually need those?

Fix it!

An issue was opened. Show all issues

From the API as it is tested, I'm not really sure I see the difference here with GMemoryInputStream?

grim Feb. 18, 2025, 9:47 a.m.

You can't add more data to a GMemoryInputStream, it's initial and then that's it unless something changed with in the past year. Although looking at https://gitlab.gnome.org/GNOME/glib/-/blob/main/gio/gmemoryinputstream.c?ref_type=heads#L288 that seems like it should be able to keep working. Guess I'll need to do some testing.

QuLogic Feb. 18, 2025, 11:38 p.m.

Isn't that what g_memory_input_stream_add_data/g_memory_input_stream_add_bytes is for?

grim Feb. 18, 2025, 11:40 p.m.

Yeah, I'm seeing that now. I think previously I tried to do this with GMemoryOutputStream and that definitely is a one and one thing.

birb/tests/test_string_stream.c (Diff revision 1)

An issue was opened. Show all issues

A 0 return here (without input count of 0) should indicate EOF. That would imply the stream could not get any new data after that, though that is happening now.
Maybe this should be G_IO_ERROR_PENDING, G_IO_ERROR_PARTIAL_INPUT, or G_IO_ERROR_WOULD_BLOCK (and/or possibly with implementing GPollableInputStream for the latter.)

grim Feb. 18, 2025, 9:47 a.m.

I mentioned in my general comment above that this might be a problem, but I hadn't found G_IO_ERROR_PARTIAL_INPUT at the time, and that does look to be the solution there.