Annotate constructor that returns a base type

 






 

 


  Review Request #3834
  —
  Created Feb. 14, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  QuLogic
 









 
 

  birb/birb
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
In that case, annotating the actual type will help bindings use the correct type.

 








  


 
 

  
Compared the gir before and after, and confirmed that the type was changed:


--- Birb-1.0.gir    2025-02-14 01:51:51.510647952 -0500
+++ build/birb/Birb-1.0.gir 2025-02-14 01:51:57.782682982 -0500
@@ -644,7 +644,7 @@
           <doc xml:space="preserve"
                filename="birb/birbqueuedoutputstream.h"
                line="92">The new stream.</doc>
-          <type name="Gio.OutputStream" c:type="GOutputStream*"/>
+          <type name="QueuedOutputStream" c:type="GOutputStream*"/>
         </return-value>
         <parameters>
           <parameter name="base_stream" transfer-ownership="none">


 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Annotate constructors that return base types
     
In that case, annotating the actual type will help bindings use the correct type.

    

   
  		
  471ddef89a265210c6dbeba4e9e7d3d8e2e594ee
  Elliott Sales de Andrade
 




    


    
    

   

  

 









 

  

   
    

     
      
      birb/birbqueuedoutputstream.h
     
    

   
  

 










     

    

   

  

  

   
   Loading...