Summary

Create the initial statement object

Review Request #3833 — Created Feb. 11, 2025 and submitted Feb. 14, 2025, 5:23 a.m.

Information

Owner

grim

Repository

seagull/seagull

Branch

default

Bugs

SEAGULL-2

Depends On

~~3831~~

Reviewers

Groups

pidgin

People

Description

This is a basic GInitable that will verify that the statement is valid and
that only one statement was given. This does not yet implement anything for
bindings, steping through results, or getting said results.

Testing Done

Ran the tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Create the initial statement object This is a basic GInitable that will verify that the statement is valid and that only one statement was given. This does not yet implement anything for bindings, steping through results, or getting said results.	727c8bacf4ee14ebf35f56cfd5f9cbfef5b8cda2

Issues

Description	From	Last Updated
This can be called more than once, in which case the existing statement->statement will leak. We should check statement->statement at …	QuLogic	Feb. 14, 2025, 5:06 a.m.
Is this different from statement->sql?	QuLogic	Feb. 14, 2025, 5:06 a.m.
Should we test this double-init?	QuLogic	Feb. 14, 2025, 5:21 a.m.

seagull/seagullstatement.c (Diff revision 1)

The issue has been resolved. Show all issues

This can be called more than once, in which case the existing statement->statement will leak.
We should check statement->statement at the start, and either fail or return early.

seagull/seagullstatement.c (Diff revision 1)

The issue has been resolved. Show all issues

Is this different from statement->sql?

grim Feb. 14, 2025, 4:55 a.m.

It shouldn't be. We can go either way, but once we add binding I'm going to add a get_expanded_sql that will call sqlite3_expanded_sql https://www.sqlite.org/c3ref/expanded_sql.html.

We store the sql because we need it for the initable to work, but i wasn't sure if sqlite will do any normalization or trimming of the sql which is anyone reason I called into the library. but I can add a unit test to check that real quick.

Change Summary:

address issues

Commits:

	Summary	ID
	Create the initial statement object This is a basic GInitable that will verify that the statement is valid and that only one statement was given. This does not yet implement anything for bindings, steping through results, or getting said results.	a6a4d89d610d3b8303cf23c42c5fe3d683ec5efc
	Create the initial statement object This is a basic GInitable that will verify that the statement is valid and that only one statement was given. This does not yet implement anything for bindings, steping through results, or getting said results.	9a5f76f8194595b8c0d506014e7be6fc8ad0d5e4

Diff:

Revision 2 (+1270 -2)

Show changes

	seagull/meson.build
	seagull/seagullstatement.h
	seagull/seagullstatement.c
	seagull/seagulltypes.h
	seagull/tests/meson.build
	seagull/tests/test_statement.c

seagull/seagullstatement.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Should we test this double-init?
```

Change Summary:

add tests for double inits and trailing's semi colons.
I skipped allowing tailing whitespace because it gets complicated because need to allocate the string to test because it could be a static string from the caller.

Commits:

	Summary	ID
	Create the initial statement object This is a basic GInitable that will verify that the statement is valid and that only one statement was given. This does not yet implement anything for bindings, steping through results, or getting said results.	9a5f76f8194595b8c0d506014e7be6fc8ad0d5e4
	Create the initial statement object This is a basic GInitable that will verify that the statement is valid and that only one statement was given. This does not yet implement anything for bindings, steping through results, or getting said results.	727c8bacf4ee14ebf35f56cfd5f9cbfef5b8cda2

Diff:

Revision 3 (+1376 -2)

Show changes

	seagull/meson.build
	seagull/seagullstatement.h
	seagull/seagullstatement.c
	seagull/seagulltypes.h
	seagull/tests/meson.build
	seagull/tests/test_statement.c

Ship it!

```
Ship It!
```

Status:: Completed