Summary

Add Hasl.Gs2Header.parse_full which returns the length of the header

Review Request #3822 — Created Feb. 7, 2025 and submitted Feb. 14, 2025, 5:29 a.m.

Information

Owner

grim

Repository

hasl/hasl

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is necessary when the Gs2 header is used as a header and we need to move
past it in a string.

Testing Done

Ran the gs2-header test under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Add Hasl.Gs2Header.parse_full which returns the length of the header This is necessary when the Gs2 header is used as a header and we need to move past it in a string.	1dcc72097d1c1515cdcddee60d734311bcbae1fa

Issues

Description	From	Last Updated
(nullable) doesn't make sense here as length is an integer not a pointer. To indicate that the caller can pass …	QuLogic	Feb. 14, 2025, 3:49 a.m.

Change Summary:

remove some gints

Commits:

	Summary	ID
	Add Hasl.Gs2Header.parse_full which returns the length of the header This is necessary when the Gs2 header is used as a header and we need to move past it in a string.	6979bdbd8a3a6dbe2ff1b7bdd6f878ff6c2d058b
	Add Hasl.Gs2Header.parse_full which returns the length of the header This is necessary when the Gs2 header is used as a header and we need to move past it in a string.	fd80bec61fa4ee6d63324960dd20641b8f5e3b3b

Diff:

Revision 2 (+340 -6)

Show changes

	hasl/haslgs2header.h
	hasl/haslgs2header.c
	hasl/tests/test-gs2-header.c

hasl/haslgs2header.h (Diff revision 2)

The issue has been resolved. Show all issues

(nullable) doesn't make sense here as length is an integer not a pointer. To indicate that the caller can pass NULL, this should be marked with (optional).

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	Add Hasl.Gs2Header.parse_full which returns the length of the header This is necessary when the Gs2 header is used as a header and we need to move past it in a string.	fd80bec61fa4ee6d63324960dd20641b8f5e3b3b
	Add Hasl.Gs2Header.parse_full which returns the length of the header This is necessary when the Gs2 header is used as a header and we need to move past it in a string.	1dcc72097d1c1515cdcddee60d734311bcbae1fa

Diff:

Revision 3 (+340 -6)

Show changes

	hasl/haslgs2header.h
	hasl/haslgs2header.c
	hasl/tests/test-gs2-header.c

Ship it!

```
Ship It!
```

Status:: Completed