Summary

IRCv3: Update the status window title when the user's nick changes

Review Request #3814 — Created Feb. 4, 2025 and submitted Feb. 7, 2025, 2:29 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-18036

Depends On

Reviewers

Groups

pidgin

People

Description

IRCv3: Update the status window title when the user's nick changes

Testing Done

Changed my nick on a local ergo server using quote and verified the title of the status window updated correctly. Also built and ran the flatpak without issue.

Commits

Summary	ID
IRCv3: Update the status window title when the user's nick changes	5271fa375b4b45264624e3e262886e91a67ee04b

Issues

Description	From	Last Updated
Is there a missing call to this helper? It seems to be only used in the single callback, and could …	QuLogic	Feb. 5, 2025, 1:21 a.m.

protocols/ircv3/purpleircv3connection.c (Diff revision 1)

The issue has been resolved. Show all issues

Is there a missing call to this helper? It seems to be only used in the single callback, and could be inlined there otherwise.

grim Feb. 4, 2025, 8:53 p.m.

I was thinking I was going to need to call it at startup and forgot to, but I just tested it on libera that has a big delay at startup as it looks up your host and it was just the status <nick> at <servername> fallback which is good.

Change Summary:

Don't use a helper function as it's not necessary.

Commits:

	Summary	ID
	IRCv3: Update the status window title when the user's nick changes	0cecff9dc326daa9d2da79903f9f8cbc193952c8
	IRCv3: Update the status window title when the user's nick changes	5271fa375b4b45264624e3e262886e91a67ee04b

Diff:

Revision 2 (+78 -32)

Show changes

	im.pidgin.Pidgin3.yml
	protocols/ircv3/meson.build
	protocols/ircv3/purpleircv3connection.c
	subprojects/ibis.wrap

Ship it!

```
Ship It!
```

Status:: Completed