Summary

Implement Hasl.Gs2Header.parse

Review Request #3813 — Created Feb. 4, 2025 and submitted Feb. 7, 2025, 2:31 a.m.

Owner

grim

Repository

hasl/hasl

Branch

default

Bugs

Depends On

Groups

People

Description

Add a method to parse gs2 headers as we need to do that to implement scram.

Testing Done

Ran the tests under valgrind and called in the turtles as well.

Commits

Summary	ID
Initial work towards GS2 Header parsing	6d9be253399b6c2fc9e2ad27acc3363785c79496

Issues

Description	From	Last Updated
There's a space too many after GMatchInfo.	ivanhoe	Feb. 6, 2025, 5:36 p.m.
regex and info are not unref'd in case of this early return.	ivanhoe	Feb. 6, 2025, 5:36 p.m.
regex and info are not unref'd in case of this early return.	ivanhoe	Feb. 6, 2025, 5:36 p.m.
The "otherwise null" is superfluous since it's already declared as nullable.	ivanhoe	Feb. 6, 2025, 5:36 p.m.

hasl/haslgs2header.c (Diff revision 1)
The issue has been resolved. Show all issues
```
There's a space too many after GMatchInfo.
```
hasl/haslgs2header.c (Diff revision 1)
The issue has been resolved. Show all issues
```
regex and info are not unref'd in case of this early return.
```
hasl/haslgs2header.c (Diff revision 1)
The issue has been resolved. Show all issues
```
regex and info are not unref'd in case of this early return.
```

hasl/haslgs2header.h (Diff revision 1)

The issue has been resolved. Show all issues

The "otherwise null" is superfluous since it's already declared as nullable.

Change Summary:

addressed issues and added some more unit tests

Commits:

	Summary	ID
	Initial work towards GS2 Header parsing	55b477a0bf1923eac41f0393f4161dd89d1770f1
	Initial work towards GS2 Header parsing	6d9be253399b6c2fc9e2ad27acc3363785c79496

Diff:

Revision 2 (+696 -32)

Ship it!