ircv3: Remove another redundant account disconnection

Review Request #3797 — Created Jan. 31, 2025 and submitted

Information

pidgin/pidgin
default

Reviewers

When ibis_client_stop is called, it will set IbisClient:connect to FALSE and IbisClient:error to the input error.

The IRCv3 protocol's notify handler for the first one disconnects the account, so the notify handler for the latter should not also disconnect the account. It is sufficient to just set the account error.

Connected to a IRC that kicked me, and didn't see any warning about purple_account_disconnect being called when already disconnected.

Summary ID
ircv3: Remove another redundant account disconnection
When `ibis_client_stop` is called, it will set `IbisClient:connect` to `FALSE` and `IbisClient:error` to the input error. The `notify` handler for the first one disconnects the account, so the `notify` handler for the latter should _not_ also disconnect the account. It is sufficient to just set the account error.
2fa1dea24a37c192a0a52d144477cb67e2c3b8ad
grim
  1. Great find, thanks!!

  2. 
      
grim
Review request changed
Status:
Completed