Summary

Avoid double-free when stopping client

Review Request #3793 — Created Jan. 31, 2025 and submitted Jan. 31, 2025, 5:45 a.m.

Owner

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Groups

People

Description

If the client is stopping normally, but closing the connection itself does error, then we set that as the error.

But ibis_client_set_error takes ownership of the error, so we shouldn't free it in that case.

Testing Done

Compiled only.

Commits

Summary	ID
Avoid double-free when stopping client If the client is stopping normally, but closing the connection itself _does_ error, then we set that as the error. But `ibis_client_set_error` takes ownership of the error, so we shouldn't free it in that case.	88e1e4e467c690313ca965ff5bca9c78501a9da2

Ship it!