Summary

Fix wrong detection of "repo in repo" check

Review Request #3792 — Created Jan. 30, 2025 and submitted Feb. 10, 2025, 9:58 p.m.

Information

Owner

aklitzing@gmail.com

Repository

grim/hgkeeper

Branch

default

Bugs

Depends On

Reviewers

Groups

People

grim

Description

Fix wrong detection of "repo in repo" check

If a repository "Dummy/RepoName-Something" exists
and we want to create "Dummy/RepoName" it was forbidden. So
let's add a / to avoid "contains" check.

This amends ebf8e3bd9e68.

Testing Done

Commits

Summary	ID	Author
Fix wrong detection of "repo in repo" check If a repository "Dummy/RepoName-Something" exists and we want to create "Dummy/RepoName" it was forbidden. So let's add a / to avoid "contains" check. This amends ebf8e3bd9e68.	7e08fdb4d2cf86a5c26a8bfbefec3a268db35278	Andre Klitzing

Issues

Description	From	Last Updated
What happens if the user puts a / at the end of their repo name, does this end up with …	grim	Feb. 10, 2025, 9:56 p.m.

access/repositories.go (Diff revision 1)

The issue has been dropped. Show all issues

What happens if the user puts a / at the end of their repo name, does this end up with with // then?

aklitzing@gmail.com Feb. 4, 2025, 8:33 a.m.

It will be filtered in NormalizeRepo with realRepoName := strings.Trim(strings.TrimPrefix(absPath, reposPath), "\\/")

grim Feb. 10, 2025, 9:56 p.m.

Awesome thanks, it's been awhile since I've been in here and couldn't remember how this works ;)

Status:: Completed

Status:: Re-opened

Ship it!

```
Great work, thanks!!
```

Status:: Completed