Summary

Add Purple.CreateConversationDetails.is_valid

Review Request #3791 — Created Jan. 29, 2025 and submitted Jan. 31, 2025, 4:26 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-18032

Depends On

Reviewers

Groups

pidgin

People

Description

This does some basic checking and creates standard errors for invalid settings
on Purple.CreateConversationDetails.

Testing Done

Ran the unit tests under valgrind and called in the turtles as well.

Commits

Summary	ID
Add Purple.CreateConversationDetails.is_valid This does some basic checking and creates standard errors for invalid settings on Purple.CreateConversationDetails.	b42a3c2e55924639e0749003adc7bde90e2b09f0

Issues

Description	From	Last Updated
This should use ngettext, though I don't know how best to use it when there are two numbers to pluralize.	QuLogic	Jan. 31, 2025, 3:55 a.m.
The comment belongs above the to-be-translated string, I think.	QuLogic	Jan. 31, 2025, 4 a.m.

libpurple/purplecreateconversationdetails.c (Diff revision 1)

The issue has been resolved. Show all issues

This should use ngettext, though I don't know how best to use it when there are two numbers to pluralize.

grim Jan. 29, 2025, 8:58 a.m.

This sounds correct I think.. https://stackoverflow.com/a/27964931

So maybe something like too many participants: %u or something?

Change Summary:

Don't bother with the number of participants as that should be usable in the ui and the caller doesn't explicitly need it.

Commits:

	Summary	ID
	Add Purple.CreateConversationDetails.is_valid This does some basic checking and creates standard errors for invalid settings on Purple.CreateConversationDetails.	826353695c6d541b2684691c13c699723ecf0bdf
	Add Purple.CreateConversationDetails.is_valid This does some basic checking and creates standard errors for invalid settings on Purple.CreateConversationDetails.	48006a69d6eafdb0359beed2305bcbd6c7da4102

Diff:

Revision 2 (+546)

Show changes

	libpurple/meson.build
	libpurple/purplecreateconversationdetails.h
	libpurple/purplecreateconversationdetails.c
	libpurple/tests/test_create_conversation_details.c

libpurple/purplecreateconversationdetails.c (Diff revision 2)
The issue has been resolved. Show all issues
```
The comment belongs above the to-be-translated string, I think.
```

Change Summary:

Move the translator comment to the right place

Commits:

	Summary	ID
	Add Purple.CreateConversationDetails.is_valid This does some basic checking and creates standard errors for invalid settings on Purple.CreateConversationDetails.	48006a69d6eafdb0359beed2305bcbd6c7da4102
	Add Purple.CreateConversationDetails.is_valid This does some basic checking and creates standard errors for invalid settings on Purple.CreateConversationDetails.	b42a3c2e55924639e0749003adc7bde90e2b09f0

Diff:

Revision 3 (+546)

Show changes

	libpurple/meson.build
	libpurple/purplecreateconversationdetails.h
	libpurple/purplecreateconversationdetails.c
	libpurple/tests/test_create_conversation_details.c

Ship it!

```
Ship It!
```

Status:: Completed