Summary

Don't set error if already cancelled

Review Request #3790 — Created Jan. 29, 2025 and submitted Jan. 29, 2025, 1:58 a.m.

Information

Owner

QuLogic

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The cancellable is only cancelled in ibis_client_stop, meaning it's either
shutting down or there's already an error, so there's no need to set one or
call ibis_client_stop again.

Testing Done

Ran ninja turtles only.

I'm not sure if this would have an effect on PIDGIN-18031?

Commits

Summary	ID
Don't set error if already cancelled The cancellable is only cancelled in `ibis_client_stop`, meaning it's either shutting down or there's already an error, so there's no need to set one or call `ibis_client_stop` again.	6cf282f028875626ed9e710ff2dcf4ab4aadd098

Issues

Description	From	Last Updated
We normally put this at the very top, above <glib/gi18n-lib.h> in this case and use angle brackets for it.	grim	Jan. 29, 2025, 1:57 a.m.

ibis/ibisclient.c (Diff revision 1)

The issue has been resolved. Show all issues

We normally put this at the very top, above <glib/gi18n-lib.h> in this case and use angle brackets for it.

Change Summary:

Remove extraneous change

Commits:

	Summary	ID
	Don't set error if already cancelled The cancellable is only cancelled in `ibis_client_stop`, meaning it's either shutting down or there's already an error, so there's no need to set one or call `ibis_client_stop` again.	0b5bc8069373bae430aca948ebbbbe75efeaad9d
	Don't set error if already cancelled The cancellable is only cancelled in `ibis_client_stop`, meaning it's either shutting down or there's already an error, so there's no need to set one or call `ibis_client_stop` again.	6cf282f028875626ed9e710ff2dcf4ab4aadd098

Diff:

Revision 2 (+30 -20)

Show changes

ibis/ibisclient.c

Ship it!

Great work and awesome find! Thank you so much!!

Status:: Completed