Fish Trophy

  
grim got a fish trophy!

  
  Fish Trophy

 






  





 

 

  

  

 




  







 




  


 
 

  
Create a Pidgin.ConversationMember widget

 






 

 


  Review Request #3773
  —
  Created Jan. 18, 2025 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This creates a widget for displaying Purple.ConversationMember's and is now
used in Pidgin.Message and Pidgin.ConversationMemberList.

Currently the context menu is broken and it's going to take a lot of work to
fix it. See the comment in the code about it.

 








  


 
 

  
Verified that the displays looked the same in messages and the member list with and without badges. Also called in the turtles.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Create a Pidgin.ConversationMember widget
      
This creates a widget for displaying Purple.ConversationMember's and is now
used in Pidgin.Message and Pidgin.ConversationMemberList.

Currently the context menu is broken and it's going to take a lot of work to
fix it. See the comment in the code about it.

     


    		
    928f1b33c58cd70ffd011a5123cbc29239053929

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
If purple_conversation_member_get_name_for_display is called with self->conversation_member shouldn't that be checked here? Also you might need to check the G_GNUC_UNUSED attributes …

      		
      
       ivanhoeivanhoe
      
      
       
      
     




     

      
       
       
PURPLE_IS_CONVERSATION_MEMBER(conversation_member) was already checked above.

      		
      
       ivanhoeivanhoe
      
      
       
      
     




     

      
       
       
Is this check necessary?

      		
      
       ivanhoeivanhoe
      
      
       
      
     




     

      
       
       
This check also seems unnecessary.

      		
      
       ivanhoeivanhoe
      
      
       
      
     


    

 There are no open issues


   

  

 







 






  

 








 














 



 

  

   




grim




   

   

  

 



 















 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginconversationmember.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    If purple_conversation_member_get_name_for_display is called with self->conversation_member shouldn't that be checked here?
    
Also you might need to check the G_GNUC_UNUSED attributes once this is fixed.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I didn't put the note in here, but if we don't pass the conversation member the initial call doesn't work due to some weird order of operation crap. I'll put the note in the ui file that describes this again.
      

      That said, we shouldn't be using self here because of that issue and I just didn't clean things up right which you caught ;)
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginconversationmember.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    PURPLE_IS_CONVERSATION_MEMBER(conversation_member) was already checked above.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginconversationmember.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Is this check necessary?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginconversationmember.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    This check also seems unnecessary.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Does it seem unnecessary because we fallback to a color for the name for display or is there something else you're seeing?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      At that point color_valid must be TRUE and doesn't need to be checked, because it either was TRUE at line 97 or at line 108.
      
 
      

      3. 


 
    


    

 
    

    6. 




  6. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  

















  

 









     

    

   

  

  

   
   Loading...