Summary

Fix some broken stuff with badges in demo and ircv3

Review Request #3767 — Created Jan. 17, 2025 and submitted Jan. 17, 2025, 5:54 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

I'm not sure if this is the cause of my crash but this code is clearly wrong
as Purple.BadgeManager.find has a transfer of none.

Testing Done

Tried to reproduce but I don't know how many items a GtkListView uses before reusing widgets so I have gave somewhere between 50 and 100 I think.

Commits

Summary	ID
Fix some broken stuff with badges in demo and ircv3 I'm not sure if this is the cause of my crash but this code is clearly wrong as Purple.BadgeManager.find has a transfer of none.	6e7306a6490619e26e94977f9dc2f7f7d1ca3074

Issues

Description	From	Last Updated
I'm not sure how this helps; doesn't PidginBadges already handle NULL? I can't see how it doesn't. And recycling occurs …	QuLogic	Jan. 17, 2025, 5:47 a.m.

The issue has been resolved. Show all issues

I'm not sure how this helps; doesn't PidginBadges already handle NULL? I can't see how it doesn't.

And recycling occurs at 200, I believe.

well the crashes don't appear to be null, it's a PURPLE_IS_BADGE(badge) that's crashing.

Actually What i think is happening here is that author gets nulled out, but then badges can't get resolved so it's still pointing to invalid memory.

Change Summary:

found a much more likely culprit

Summary:

Attempt to fix a crash with badges on messages

Fix some broken stuff with badges in demo and ircv3

Description:

~		I haven't been able to reliably reproduce this but I think this is the cause
~		of the random crash on PURPLE_IS_BADGE. What I think is happening is that
	~	I'm not sure if this is the cause of my crash but this code is clearly wrong
	~	as Purple.BadgeManager.find has a transfer of none.
-		someone with a badge sends a message and that PidginMessage widget gets reused
-		for the event message which doesn't have an author which then leaves badges
-		pointing to invalid memory.
-
-		This forces PidginMessage to always have a valid badges.

Commits:

	Summary	ID
	Attempt to fix a crash with badges on messages I haven't been able to reliably reproduce this but I think this is the cause of the random crash on PURPLE_IS_BADGE. What I think is happening is that someone with a badge sends a message and that PidginMessage widget gets reused for the event message which doesn't have an author which then leaves badges pointing to invalid memory. This forces PidginMessage to always have a valid badges.	c46eebf7039ad6b1afcde1e0f1ebd0601d80f32a
	Fix some broken stuff with badges in demo and ircv3 I'm not sure if this is the cause of my crash but this code is clearly wrong as Purple.BadgeManager.find has a transfer of none.	6e7306a6490619e26e94977f9dc2f7f7d1ca3074

Diff:

	protocols/demo/purpledemoprotocolconversation.c
	protocols/ircv3/purpleircv3messagehandlers.c

Ship it!