Summary

Implement Purple.Attachments

Review Request #3758 — Created Jan. 14, 2025 and submitted Jan. 17, 2025, 3:22 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3756~~

Blocks

3759

Reviewers

Groups

pidgin

People

Description

This is a simple helper collection for Purple.Attachment.

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Initial work on Purple.Attachments	238f1cf81e4d73b6bd3bd4cc5210f35754d1da38

Issues

Description	From	Last Updated
g_ptr_array_add adds the pointer to the end of the array, shouldn't it be sufficient to do g_list_model_items_changed(G_LIST_MODEL(attachments), len, 0, 1)?	ivanhoe	Jan. 16, 2025, 7:17 p.m.
Why is it necessary to create a new attachment object for needle?	ivanhoe	Jan. 16, 2025, 7:18 p.m.

Change Summary:

Added a fine_with_id function.

Summary:

Initial work on Purple.Attachments

Implement Purple.Attachments

Description:

~		Initial work on Purple.Attachments
	~	This is a simple helper collection for Purple.Attachment.

Commits:

	Summary	ID
	Initial work on Purple.Attachments	8eb020172e33005322584560640b80333d3e6642
	Initial work on Purple.Attachments	c142ed0603da0f8cccaa138e59080c30bf74a5c4

Diff:

Revision 2 (+1220 -2)

Show changes

	libpurple/meson.build
	libpurple/purpleattachments.h
	libpurple/purpleattachments.c
	libpurple/tests/meson.build
	libpurple/tests/test_attachments.c

libpurple/purpleattachments.c (Diff revision 2)

The issue has been resolved. Show all issues

g_ptr_array_add adds the pointer to the end of the array, shouldn't it be sufficient to do g_list_model_items_changed(G_LIST_MODEL(attachments), len, 0, 1)?

grim Jan. 16, 2025, 1:18 a.m.

Yes it should. I copied this from badges which was prepending and clearly missed this bit in the cleanup.

libpurple/purpleattachments.c (Diff revision 2)

The issue has been resolved. Show all issues

Why is it necessary to create a new attachment object for needle?

grim Jan. 16, 2025, 1:18 a.m.

Because my tired mind was being dumb apparently? :-D

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Initial work on Purple.Attachments	c142ed0603da0f8cccaa138e59080c30bf74a5c4
	Initial work on Purple.Attachments	238f1cf81e4d73b6bd3bd4cc5210f35754d1da38

Diff:

Revision 3 (+1206 -2)

Show changes

	libpurple/meson.build
	libpurple/purpleattachments.h
	libpurple/purpleattachments.c
	libpurple/tests/meson.build
	libpurple/tests/test_attachments.c

Ship it!

```
Ship It!
```

Status:: Completed