Summary

Add a Purple.Attachment:inline property and other cleanups

Review Request #3756 — Created Jan. 14, 2025 and submitted Jan. 17, 2025, 3:21 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

3758

Reviewers

Groups

pidgin

People

Description

Also add and equal function and some unit tests.

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Add a Purple.Attachment:inline property and other cleanups I also added unit tests which were missing.	93996e9119a26c90dc292e346f74ce7e86757250

Issues

Description	From	Last Updated
The last part sounds weird. Maybe it should be "as an external attachment", but I'm not sure.	ivanhoe	Jan. 16, 2025, 7:14 p.m.
Parameter descriptions shouldn't end with a period.	ivanhoe	Jan. 16, 2025, 7:15 p.m.
Parameter descriptions should start with a or the.	ivanhoe	Jan. 16, 2025, 7:15 p.m.
s/nor/or	ivanhoe	Jan. 16, 2025, 7:15 p.m.

Change Summary:

Add purple_attachment_equal

Commits:

	Summary	ID
	Add a Purple.Attachment:inline property and other cleanups I also added unit tests which were missing.	90acee5e269abf801b795f9ef25f4fbace7e5881
	Add a Purple.Attachment:inline property and other cleanups I also added unit tests which were missing.	10da8a5601bbaa5b406b5dc8c7b89f561a4d0273

Diff:

Revision 2 (+624 -66)

Show changes

	libpurple/purpleattachment.h
	libpurple/purpleattachment.c
	libpurple/tests/meson.build
	libpurple/tests/test_attachment.c

Description:: ~
I also added unit tests which were missing.
~
Also add and equal function and some unit tests.

libpurple/purpleattachment.c (Diff revision 2)

The issue has been resolved. Show all issues

The last part sounds weird. Maybe it should be "as an external attachment", but I'm not sure.

libpurple/purpleattachment.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Parameter descriptions shouldn't end with a period.
```
libpurple/purpleattachment.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Parameter descriptions should start with a or the.
```
libpurple/purpleattachment.h (Diff revision 2)
The issue has been resolved. Show all issues
```
s/nor/or
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Add a Purple.Attachment:inline property and other cleanups I also added unit tests which were missing.	10da8a5601bbaa5b406b5dc8c7b89f561a4d0273
	Add a Purple.Attachment:inline property and other cleanups I also added unit tests which were missing.	93996e9119a26c90dc292e346f74ce7e86757250

Diff:

Revision 3 (+624 -66)

Show changes

	libpurple/purpleattachment.h
	libpurple/purpleattachment.c
	libpurple/tests/meson.build
	libpurple/tests/test_attachment.c

Ship it!

```
Ship It!
```

Status:: Completed

~		I also added unit tests which were missing.
	~	Also add and equal function and some unit tests.