Summary

Add properties to track whether conversation properties are editable

Review Request #3739 — Created Jan. 9, 2025 and submitted Jan. 13, 2025, 2:42 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3738~~

Groups

People

Description

This covers avatars, descriptions, titles, and topics.

Testing Done

Ran the conversation tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Add properties to track whether conversation properties are editable This covers avatars, descriptions, titles, and topics.	151558225165aa309776114e4183525ce6a7c2fc

Issues

Description	From	Last Updated
Not a big deal, but why is this one set/get while the others are get/set order?	QuLogic	Jan. 9, 2025, 9:20 p.m.

libpurple/purpleconversation.c (Diff revision 1)

The issue has been resolved. Show all issues

Not a big deal, but why is this one set/get while the others are get/set order?

Because the original thing I copy pasted from was in that order. But I'll fix it quick.

Change Summary:

reorder some stuff

Commits:

	Summary	ID
	Add properties to track whether conversation properties are editable This covers avatars, descriptions, titles, and topics.	a28b53d293ec149dd2d29515225e6c4aaeddc762
	Add properties to track whether conversation properties are editable This covers avatars, descriptions, titles, and topics.	a132f9405a74387793a29a013d46f7baec8f468b

Diff:

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c

Ship it!

Change Summary:

rebased

Commits:

	Summary	ID
	Add properties to track whether conversation properties are editable This covers avatars, descriptions, titles, and topics.	a132f9405a74387793a29a013d46f7baec8f468b
	Add properties to track whether conversation properties are editable This covers avatars, descriptions, titles, and topics.	151558225165aa309776114e4183525ce6a7c2fc

Diff:

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c