Summary

Add some additional methods to Purple.ProtocolConversation

Review Request #3738 — Created Jan. 9, 2025 and submitted Jan. 13, 2025, 8:37 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

3739

Groups

People

Description

This adds virtual functions for setting the title and description as well as
some additional implements methods that we were missing.

Testing Done

Ran the tests under valgrind and called in the turtles.

Commits

Summary	ID
Add some additional methods to Purple.ProtocolConversation This adds virtual functions for setting the title and description as well as some additional implements methods that we were missing.	2256026917af86a6b373c4c42df4c62385cb00af

Issues

Description	From	Last Updated
setting topics	QuLogic	Jan. 13, 2025, 8:24 a.m.
This is the third-different description of an _implements_ function in this RR.	QuLogic	Jan. 13, 2025, 8:25 a.m.
true/false	QuLogic	Jan. 13, 2025, 8:25 a.m.
true/false	QuLogic	Jan. 13, 2025, 8:25 a.m.
This can use g_task_return_new_error, no?	QuLogic	Jan. 13, 2025, 8:25 a.m.
Ditto.	QuLogic	Jan. 13, 2025, 8:25 a.m.
Second paragraph is still inconsistent between these.	QuLogic	Jan. 13, 2025, 8:35 a.m.
Ditto.	QuLogic	Jan. 13, 2025, 8:35 a.m.

libpurple/purpleprotocolconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
setting topics
```
libpurple/purpleprotocolconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
This is the third-different description of an _implements_ function in this RR.
```
libpurple/purpleprotocolconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
true/false
```
libpurple/purpleprotocolconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
true/false
```
libpurple/tests/test_protocol_conversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This can use g_task_return_new_error, no?
```
libpurple/tests/test_protocol_conversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```

Change Summary:

rebased, addressed issues, and bumped the glib requirement to 2.80.

Commits:

	Summary	ID
	Add some additional methods to Purple.ProtocolConversation This adds virtual functions for setting the title and description as well as some additional implements methods that we were missing.	d2aa432ab723cebf65134f84647dceeb619fe1cd
	Add some additional methods to Purple.ProtocolConversation This adds virtual functions for setting the title and description as well as some additional implements methods that we were missing.	1de1956ed86f59887793daf93a722ffedadb46fe

Diff:

Revision 2 (+1450 -6)

	meson.build
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

libpurple/purpleprotocolconversation.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Second paragraph is still inconsistent between these.
```
libpurple/purpleprotocolconversation.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Ditto.
```

Change Summary:

sorry, i think i have everything now though... I hope :-D

Commits:

	Summary	ID
	Add some additional methods to Purple.ProtocolConversation This adds virtual functions for setting the title and description as well as some additional implements methods that we were missing.	1de1956ed86f59887793daf93a722ffedadb46fe
	Add some additional methods to Purple.ProtocolConversation This adds virtual functions for setting the title and description as well as some additional implements methods that we were missing.	2256026917af86a6b373c4c42df4c62385cb00af

Diff:

Revision 3 (+1448 -6)

	meson.build
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Ship it!