Summary

Add Hasl.Context:server-mechanisms

Review Request #3731 — Created Jan. 3, 2025 and submitted Jan. 13, 2025, 1:18 a.m.

Information

Owner

grim

Repository

hasl/hasl

Branch

default

Bugs

HASL-11

Depends On

Blocks

3732

Reviewers

Groups

pidgin

People

Description

This allows users to set both allowed and server mechanisms and lets hasl
determine which to use, preferring allowed over the server advertised ones.

Testing Done

Ran the new tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Add Hasl.Context:server-mechanisms This lets allows users to set both allowed and server mechanisms and lets hasl determine which to use, preferring allowed over the server advertised ones.	3a7bc97aac9bcebf11d565d25e065085d7e11002

Issues

Description	From	Last Updated
Should you not be taking the union of allowed and server-advertised mechanisms when both are specified?	QuLogic	Jan. 13, 2025, 1:09 a.m.
s/fallback/fall back/	QuLogic	Jan. 13, 2025, 1:17 a.m.

The issue has been resolved. Show all issues

Should you not be taking the union of allowed and server-advertised mechanisms when both are specified?

grim Jan. 7, 2025, 4:25 a.m.

Server advertisments aren't a requirement and even then, they don't necessarily advertise everything they support. I thought libera did this but I can't seem to verify that right now. But regardless, server advertisement is protocol specific so there's never going to be anyting consistent spec/implementation wise.

That said, I'm wondering if we should automatically use the supported mechanisms if allowed and server mechanisms is empty. That seems okay I think?

grim Jan. 11, 2025, 1:13 a.m.

I end up using available mechanisms if no mechanisms were specified.

Change Summary:

Fall back to supported mechanisms if the user and server didn't specify any.

I also opened HASL-12 to fix the ordering of get_supported_mechanisms at a later time.

Commits:

	Summary	ID
	Add Hasl.Context:server-mechanisms This lets allows users to set both allowed and server mechanisms and lets hasl determine which to use, preferring allowed over the server advertised ones.	7ac0754f752d4d8fcb7d53473b04d895ffce20b3
	Add Hasl.Context:server-mechanisms This lets allows users to set both allowed and server mechanisms and lets hasl determine which to use, preferring allowed over the server advertised ones.	4726ff735035f677023f58f926e65e864b8aaf4c

Diff:

Revision 2 (+570 -126)

Show changes

	hasl/haslcontext.h
	hasl/haslcontext.c
	hasl/tests/test-context.c

Change Summary:: Fix typo.
Description:: ~
This lets allows users to set both allowed and server mechanisms and lets hasl
~
This allows users to set both allowed and server mechanisms and lets hasl
determine which to use, preferring allowed over the server advertised ones.

Ship it!

```
Ship It!
```
hasl/haslcontext.c (Diff revision 2)
The issue has been resolved. Show all issues
```
s/fallback/fall back/
```

Change Summary:

Fix typo

Commits:

	Summary	ID
	Add Hasl.Context:server-mechanisms This lets allows users to set both allowed and server mechanisms and lets hasl determine which to use, preferring allowed over the server advertised ones.	4726ff735035f677023f58f926e65e864b8aaf4c
	Add Hasl.Context:server-mechanisms This lets allows users to set both allowed and server mechanisms and lets hasl determine which to use, preferring allowed over the server advertised ones.	3a7bc97aac9bcebf11d565d25e065085d7e11002

Diff:

Revision 3 (+570 -126)

Show changes

	hasl/haslcontext.h
	hasl/haslcontext.c
	hasl/tests/test-context.c

Status:: Completed

~		This lets allows users to set both allowed and server mechanisms and lets hasl
	~	This allows users to set both allowed and server mechanisms and lets hasl
		determine which to use, preferring allowed over the server advertised ones.

hasl/haslcontext.c (Diff revision 2)