Fix some PURPLE_IS_CONVERSATION_MEMEBER assertion failures

Review Request #3710 — Created Jan. 1, 2025 and submitted

Information

pidgin/pidgin
default

Reviewers

This cropped up when we changed Purple.Message:author to a
Purple.ConversationMember. It's valid for event messages to not have an author
and the old code was okay with that, but we didn't realize that during the
conversion. So now we just do some instance checks before calling the
functions.

Joined an IRC channel and had another client join and part and verified the assertion warnings were gone.

Summary ID
Fix some PURPLE_IS_CONVERSATION_MEMEBER assertion failures
This cropped up when we changed Purple.Message:author to a Purple.ConversationMember. It's valid for event messages to not have an author and the old code was okay with that, but we didn't realize that during the conversion. So now we just do some instance checks before calling the functions.
b1a0a4e1f2ae062e5174a9e2a085d9d70e3ca7db
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed