Summary

Add Purple.Contact.compare and Purple.Contact.equal methods

Review Request #3693 — Created Dec. 3, 2024 and submitted Dec. 6, 2024, 9:14 p.m.

Information

Owner

ivanhoe

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17927

Depends On

Reviewers

Groups

pidgin

People

Description

Add Purple.Contact.compare and Purple.Contact.equal methods

Testing Done

Ran the unit test in valgrind.

Commits

Summary	ID
Add Purple.Contact.compare and Purple.Contact.equal methods	0627e2d5078cf08c309ed6fca67210c8b7b4df1c

Issues

Description	From	Last Updated
why use g_object_set here instead of the actual setter?	grim	Dec. 6, 2024, 8:56 p.m.
ditto	grim	Dec. 6, 2024, 8:56 p.m.

libpurple/tests/test_contact.c (Diff revision 1)
The issue has been dropped. Show all issues
```
why use g_object_set here instead of the actual setter?
```

libpurple/tests/test_contact.c (Diff revision 1)

The issue has been dropped. Show all issues

ditto

ivanhoe Dec. 6, 2024, 7:45 p.m.

There's no public purple_account_set_id.

grim Dec. 6, 2024, 7:56 p.m.

Ugh that property is a mess from when account was a ContactInfo and we thought the protocol would be updating the id... But that was wrong as libpurple needs to manage it. Apparently this never got updated to be construct only which is what that probably should be.

So, we could take this review request as is and then make that property construct only in a latter review request or adjust that here. I'm good either way and leave it up to you to decide ;)

ivanhoe Dec. 6, 2024, 8:06 p.m.

Not sure what needs to be done exactly so I'd rather leave this review request as is.

grim Dec. 6, 2024, 8:08 p.m.

Basically it'd just be updating the property flags in purple_account_class_init to use G_PARAM_CONSTRUCT_ONLY instead of G_PARAM_CONSTRUCT but then the unit tests would have to be refactored because g_object_set wouldn't work anymore.

At any rate I'll finish reviewing this shortly and we can go from there.

Change Summary:

Replaced g_object_set where possible.

Commits:

	Summary	ID
	Add Purple.Contact.compare and Purple.Contact.equal methods	6e018abcb34f6c5e252c56f292156ce830dbb8a7
	Add Purple.Contact.compare and Purple.Contact.equal methods	0627e2d5078cf08c309ed6fca67210c8b7b4df1c

Diff:

Revision 2 (+564)

Show changes

	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/tests/test_contact.c

Ship it!

```
Great work, thanks!!
```

Status:: Completed